Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mautrix-whatsapp: 2019-09-03 -> 2019-11-17 #74646

Merged
merged 1 commit into from Dec 4, 2019
Merged

mautrix-whatsapp: 2019-09-03 -> 2019-11-17 #74646

merged 1 commit into from Dec 4, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 29, 2019 •
edited

Motivation for this change

Several new bugfixes on master: https://github.com/tulir/mautrix-whatsapp/compare/22fb5c125db1a0a3a8be8e8e09e92bb38718e6bf..0fba1db6aa88a95ff567f44aa9be7ce6ef24787f

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from Vskilet and kalbasit November 29, 2019 16:11
@Ma27 Ma27 merged commit d6f8d41 into NixOS:master Dec 4, 2019
@Ma27 Ma27 deleted the bump-mautrix-whatsapp branch December 4, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@Vskilet Vskilet Awaiting requested review from Vskilet

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @prusnak