Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libzip: 1.3.0 -> 1.5.2 #68597

Closed
wants to merge 1 commit into from
Closed

libzip: 1.3.0 -> 1.5.2 #68597

wants to merge 1 commit into from

Conversation

aanderse
Copy link
Member

Motivation for this change

While fixing viking I noticed libzip is out of date. I haven't ran a full nix-review on this, but mysql-workbench did compile. More to come.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member Author

Output of nix-review:

https://github.com/NixOS/nixpkgs/pull/68597
23 package are marked as broken and were skipped:
gimpPlugins.focusblur gimpPlugins.texturize hhvm libsForQt511.khotkeys natron php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 phpPackages-unit.php_excel phpPackages-unit.v8 phpPackages-unit.v8js phpPackages.php_excel phpPackages.v8 python37Packages.cntk qgis qgis-unwrapped

4 package failed to build:
cntk mysql-workbench python27Packages.cntk vcv-rack

216 package were build:
ahoviewer arcanist ark collectd collectd-data deadbeef deadbeef-with-plugins digikam dolphin dragon drush dsview ebook_tools elisa fileshelter freedink gImageReader gimp gimp-with-plugins gimpPlugins.exposureBlend gimpPlugins.fourier gimpPlugins.gap gimpPlugins.gimplensfun gimpPlugins.gmic gimpPlugins.lightning gimpPlugins.lqrPlugin gimpPlugins.resynthesizer gimpPlugins.ufraw gimpPlugins.waveletSharpen gwenview haskellPackages.LibZip haskellPackages.bindings-libzip icingaweb2 ideviceinstaller idevicerestore k3b kcachegrind kde-cli-tools kdeApplications.baloo-widgets kdeApplications.dolphin-plugins kdenlive kfind okular libsForQt5.baloo libsForQt5.kfilemetadata kdeplasma-addons kdev-php kdev-python kdevelop kdevelop-unwrapped kile kmenuedit kwin-tiling plasma5.khotkeys libsForQt511.baloo libsForQt511.kfilemetadata libsigrok libsigrok-0-3-0 libsigrok4dsl libsigrokdecode libykneomgr libzip lsp-plugins lutris lutris-free matomo mgba mudlet nagios nextcloud-news-updater openlierox openrct2 openscad osrm-backend peruse pgloader phoronix-test-suite php php-embed php-unit php72 php72-embed php72-unit phpPackages-unit.apcu phpPackages-unit.apcu_bc phpPackages-unit.ast phpPackages-unit.box phpPackages-unit.composer phpPackages-unit.couchbase phpPackages-unit.event phpPackages-unit.igbinary phpPackages-unit.imagick phpPackages-unit.mailparse phpPackages-unit.memcached phpPackages-unit.mongodb phpPackages-unit.oci8 phpPackages-unit.pcs phpPackages-unit.pdo_sqlsrv phpPackages-unit.php-cs-fixer phpPackages-unit.php-parallel-lint phpPackages-unit.phpcbf phpPackages-unit.phpcs phpPackages-unit.phpstan phpPackages-unit.pinba phpPackages-unit.protobuf phpPackages-unit.redis phpPackages-unit.sqlsrv phpPackages-unit.xdebug phpPackages-unit.yaml phpPackages-unit.zmq php72Packages.apcu php72Packages.apcu_bc php72Packages.ast php72Packages.box php72Packages.composer php72Packages.couchbase php72Packages.event php72Packages.igbinary php72Packages.imagick php72Packages.mailparse php72Packages.memcached php72Packages.mongodb php72Packages.oci8 php72Packages.pcs php72Packages.pdo_sqlsrv php72Packages.php-cs-fixer php72Packages.php-parallel-lint php72Packages.phpcbf php72Packages.phpcs php72Packages.phpstan php72Packages.pinba php72Packages.protobuf php72Packages.redis php72Packages.sqlsrv php72Packages.xdebug php72Packages.yaml php72Packages.zmq php73Packages-unit.apcu php73Packages-unit.apcu_bc php73Packages-unit.ast php73Packages-unit.box php73Packages-unit.composer php73Packages-unit.couchbase php73Packages-unit.event php73Packages-unit.igbinary php73Packages-unit.imagick php73Packages-unit.mailparse php73Packages-unit.memcached php73Packages-unit.mongodb php73Packages-unit.oci8 php73Packages-unit.pcs php73Packages-unit.pdo_sqlsrv php73Packages-unit.php-cs-fixer php73Packages-unit.php-parallel-lint php73Packages-unit.phpcbf php73Packages-unit.phpcs php73Packages-unit.phpstan php73Packages-unit.pinba php73Packages-unit.protobuf php73Packages-unit.redis php73Packages-unit.sqlsrv php73Packages-unit.xdebug php73Packages-unit.yaml phpPackages.apcu phpPackages.apcu_bc phpPackages.ast phpPackages.box phpPackages.composer phpPackages.couchbase phpPackages.event phpPackages.igbinary phpPackages.imagick phpPackages.mailparse phpPackages.memcached phpPackages.mongodb phpPackages.oci8 phpPackages.pcs phpPackages.pdo_sqlsrv phpPackages.php-cs-fixer phpPackages.php-parallel-lint phpPackages.phpcbf phpPackages.phpcs phpPackages.phpstan phpPackages.pinba phpPackages.protobuf phpPackages.redis phpPackages.sqlsrv phpPackages.xdebug phpPackages.yaml plasma-desktop plasma-workspace powerdevil systemsettings powerline-rs ppsspp pulseeffects pulseview python27Packages.r2pipe python37Packages.r2pipe qcachegrind r2-for-cutter radare2 radare2-cutter runzip sc-im sigrok-cli sit subsurface tiscamera tldr ufraw unit wp-cli xournalpp yle-dl yubikey-neo-manager

It seems as if something has changed in mysql-workbench since I tried this lately...? I'll look into this hopefully soon.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 29, 2019

Done in #68044

@c0bw3b c0bw3b closed this Nov 29, 2019
@aanderse
Copy link
Member Author

Thanks! 🎉

@aanderse aanderse deleted the libzip branch November 29, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @c0bw3b