(triage) is this still relevant?

Yes, I just fixed the comments (thanks @matthewbauer, and sorry for the delay).

Can you give us some kind of description for those various other things that you added? The .rmeta addition (which is now the default) has what kind of consequences? I haven't really found a use-case for them thus I am eager to learn about it.

Actually, I don't really know! The .rmeta was added in an attempt to mimic more closely what cargo does now (as opposed to what it was doing when carnix was started). The rmetas are supposed to speed up compilation, although I have no data about this, but might be a good idea to do in the future anyway.

I introduced them before I found out about dontStrip. I haven't been using Carnix too much recently, I could maybe try to benchmark it (and possibly split this PR).

Actually, I don't really know! The .rmeta was added in an attempt to mimic more closely what cargo does now (as opposed to what it was doing when carnix was started). The rmetas are supposed to speed up compilation, although I have no data about this, but might be a good idea to do in the future anyway.

I introduced them before I found out about dontStrip. I haven't been using Carnix too much recently, I could maybe try to benchmark it (and possibly split this PR).

My understanding is that those files are useful for cargo when buildings dependencies in parallel. Since we have them properly isolated and the processes do not know anything about each other we probably shouldn't take that route.

@GrahamcOfBorg buildRustCrateTests

I believe the rmeta are supposed to be barebones specifications of the library, which might potentially result in smaller closures.

I believe the rmeta are supposed to be barebones specifications of the library, which might potentially result in smaller closures.

I am tempted to give them a go. I currently have a rare issue where linking multiple .rlib files from different builders results in metadata hashsum mismatches. Maybe that fixes it.

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

I marked this as stale due to inactivity. → More info