Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tpm2-abrmd: 2.2.0 -> 2.3.0 #74665

Closed
wants to merge 1 commit into from
Closed

tpm2-abrmd: 2.2.0 -> 2.3.0 #74665

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/tpm2-abrmd/versions.

meta.description for tpm2-abrmd is: '"TPM2 resource manager, accessible via D-Bus"'.

meta.homepage for tpm2-abrmd is: '"https://github.com/tpm2-software/tpm2-tools"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

20 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
discover
fwupd
gnome-firmware-updater
gnome3.gnome-software
plasma5.discover
tpm2-abrmd
tpm2-tools

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/92imn58rzhkvmk3l01484qmqryfpa36n-tpm2-abrmd-2.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A tpm2-abrmd https://github.com/r-ryantm/nixpkgs/archive/5dee363e7923fe0e60994e5e24ca5bc46afcd5df.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/92imn58rzhkvmk3l01484qmqryfpa36n-tpm2-abrmd-2.3.0
ls -la /nix/store/92imn58rzhkvmk3l01484qmqryfpa36n-tpm2-abrmd-2.3.0/bin

cc @lschuermann for testing.

@ofborg ofborg bot requested a review from lschuermann November 29, 2019 19:19
@lschuermann
Copy link
Member

From the release notes:

[...]
Changed
    Replaced custom dynamic TCTI loading code with libtss2-tctildr from
    upstream tpm2-tss repo.
[...]

As the TCTI loading tends to cause some issues with stripped RPATHS and non-FHS, I'll give this some thorough testing.

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented Feb 15, 2020 •
edited

@lschuermann

I'll give this some thorough testing.

Any update?

@r-ryantm r-ryantm closed this Jun 11, 2020
@r-ryantm r-ryantm deleted the auto-update/tpm2-abrmd branch June 11, 2020 04:57
@ryantm ryantm restored the auto-update/tpm2-abrmd branch June 11, 2020 05:12
@ryantm ryantm reopened this Jun 11, 2020
@r-ryantm r-ryantm closed this Jun 14, 2020
@r-ryantm r-ryantm deleted the auto-update/tpm2-abrmd branch June 14, 2020 03:31
@ryantm ryantm restored the auto-update/tpm2-abrmd branch June 14, 2020 04:15
@ryantm ryantm reopened this Jun 14, 2020
@lschuermann
Copy link
Member

Mhm, acutally this seems to break abrmd on my system

tss@nixos $ /nix/store/xpry3r6gd9bydl9mklh8w8anp6ri09wx-tpm2-abrmd-2.3.0/bin/tpm2-abrmd

** (process:16419): WARNING **: 09:11:50.570: tcti_conf before: "device:/dev/tpm0"

** (tpm2-abrmd:16419): WARNING **: 09:11:50.572: tcti_conf after: "device:/dev/tpm0"
ERROR:tcti:src/tss2-tcti/tctildr.c:418:Tss2_TctiLdr_Initialize_Ex() Failed to instantiate TCTI 

** (tpm2-abrmd:16419): CRITICAL **: 09:11:50.572: init_thread_func: failed to create TCTI with conf "device:/dev/tpm0"

(tpm2-abrmd:16419): GLib-GIO-CRITICAL **: 09:11:50.572: g_bus_unown_name: assertion 'owner_id > 0' failed

This behavior is usually seen when no TPM is installed or the permissions are wrong. Given that my exact setup (using identical permissions) works with the previous version of the abrmd leads me to believe this update could be responsible for breaking this. I will investigate further, given that 2.3.1 fixes infrastructure around this exact error for systems without a TPM2 present (note: does not apply to me!) I might as well test this version and create a PR on the latest release.

This was referenced Jun 16, 2020
Closed
Closed
@JohnAZoidberg
Copy link
Member

Superceded by #90599

@ryantm ryantm deleted the auto-update/tpm2-abrmd branch June 16, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lschuermann lschuermann Awaiting requested review from lschuermann

Assignees

@lschuermann lschuermann

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @lschuermann @JohnAZoidberg @ryantm