nixos/lxd: add productionSetup option #71978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megheaiulian
reviewed
Dec 3, 2019
nixos/modules/virtualisation/lxd.nix
Outdated
| @@ -69,8 +81,9 @@ in | |||
| ExecStart = "@${pkgs.lxd.bin}/bin/lxd lxd --group lxd"; | |||
| Type = "simple"; | |||
| KillMode = "process"; # when stopping, leave the containers alone | |||
| LimitMEMLOCK = mkIf cfg.productionSetup "infinity"; | |||
| LimitNOFILE = mkIf cfg.productionSetup "1048576"; | |||
There was a problem hiding this comment.
I think these service settings should always be added (not only in production). The debian lxd packages seems to do that too https://github.com/lxc/lxd-pkg-ubuntu/blob/dpm-bionic/debian/lxd.service#L15.
There was a problem hiding this comment.
Good point. I've added some stuff from https://github.com/lxc/lxd-pkg-ubuntu/blob/dpm-xenial/debian/lxd.service, how does this look?
There was a problem hiding this comment.
Looks great! I would only rename the option from productionSetup to recommendedSysctlSettings in the style of the recommended* nginx options in nixos: https://nixos.org/nixos/options.html#nginx.reco
megheaiulian
approved these changes
Dec 6, 2019
|
@mt-caret I am not sure who we should be ping to review and merge this ? |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds an option to fix errors that may come up for ZFS storage backend users.
See https://discuss.linuxcontainers.org/t/weird-error-for-zfs-storage-backend/6008/3 for details.
Things done
Tested on own machine.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)