[css-grid] Align stretching replaced items #19862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
javifernandez,
mrego,
plinss,
rachelandrew,
svillar and
tabatkins
RMonteR
changed the title
javifernandez
approved these changes
Jan 10, 2020
RMonteR
force-pushed
the
align-stretching-replaced-items
branch
from
bc642aa
to
31642b2
Compare
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 20, 2020
This patch removes some outdated grid-align tests from: third_party/blink/web_tests/fast/css-grid-layout/ The tests have been adapted and moved to WPT with the following PR: * #19862 * #19823 and can now be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch introduces also a minor correction to the description inside the <p> divs of grid-align-stretching-replaced-items.html. Change-Id: Ie8e3544e67e7238170d202394a43a6936a9ff07d
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 24, 2020
This patch removes some outdated grid-align tests from: third_party/blink/web_tests/fast/css-grid-layout/ The tests have been adapted and moved to WPT with the following PR: * #19862 * #19823 and can now be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch introduces also a minor correction to the description inside the <p> divs of grid-align-stretching-replaced-items.html. Change-Id: Ie8e3544e67e7238170d202394a43a6936a9ff07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010769 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#734861}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 24, 2020
This patch removes some outdated grid-align tests from: third_party/blink/web_tests/fast/css-grid-layout/ The tests have been adapted and moved to WPT with the following PR: * #19862 * #19823 and can now be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch introduces also a minor correction to the description inside the <p> divs of grid-align-stretching-replaced-items.html. Change-Id: Ie8e3544e67e7238170d202394a43a6936a9ff07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010769 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#734861}
pull bot
pushed a commit
to FreddyZeng/chromium
that referenced
this pull request
Jan 24, 2020
This patch removes some outdated grid-align tests from: third_party/blink/web_tests/fast/css-grid-layout/ The tests have been adapted and moved to WPT with the following PR: * web-platform-tests/wpt#19862 * web-platform-tests/wpt#19823 and can now be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch introduces also a minor correction to the description inside the <p> divs of grid-align-stretching-replaced-items.html. Change-Id: Ie8e3544e67e7238170d202394a43a6936a9ff07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010769 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#734861}
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 2, 2020
…testonly Automatic update from web-platform-tests Remove outdated css grid-align tests This patch removes some outdated grid-align tests from: third_party/blink/web_tests/fast/css-grid-layout/ The tests have been adapted and moved to WPT with the following PR: * web-platform-tests/wpt#19862 * web-platform-tests/wpt#19823 and can now be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch introduces also a minor correction to the description inside the <p> divs of grid-align-stretching-replaced-items.html. Change-Id: Ie8e3544e67e7238170d202394a43a6936a9ff07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010769 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#734861} -- wpt-commits: a93655df98909406dc2510b4ad84aca449b5f7ce wpt-pr: 21267
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 5, 2020
…testonly Automatic update from web-platform-tests Remove outdated css grid-align tests This patch removes some outdated grid-align tests from: third_party/blink/web_tests/fast/css-grid-layout/ The tests have been adapted and moved to WPT with the following PR: * web-platform-tests/wpt#19862 * web-platform-tests/wpt#19823 and can now be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch introduces also a minor correction to the description inside the <p> divs of grid-align-stretching-replaced-items.html. Change-Id: Ie8e3544e67e7238170d202394a43a6936a9ff07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010769 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#734861} -- wpt-commits: a93655df98909406dc2510b4ad84aca449b5f7ce wpt-pr: 21267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.