Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-backup: init at 0.2.0 #71898

Merged
merged 1 commit into from Oct 25, 2019
Merged

git-backup: init at 0.2.0 #71898

merged 1 commit into from Oct 25, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 24, 2019

Motivation for this change

Add https://github.com/jsdw/git-backup

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[4 built, 2 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71898
1 package were build:
git-backup

Just curious about this though:

[nix-shell:~/.cache/nix-review/pr-71898]$ git backup
error: The following required arguments were not provided:
    <source>

USAGE:
    git-backup [FLAGS] [OPTIONS] <source> [destination]

For more information try --help

[nix-shell:~/.cache/nix-review/pr-71898]$ git backup --help
No manual entry for git-backup

looks like it's trying to reference some man pages which aren't getting installed. Does the build generate any? I don't see anything in the source, as far as man pages go

I know git like's to use man pages, could be that this project doesn't have any. Which is okay

@jonringer
Copy link
Contributor

I just did a tree on the build dir after build, and there's nothing. Guess it's an upstream issue then : /

@jonringer jonringer merged commit 9e5a30b into NixOS:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @jonringer