Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 77.0.3865.120 -> 78.0.3904.70 #71749

Merged
merged 1 commit into from Oct 24, 2019
Merged

chromium: 77.0.3865.120 -> 78.0.3904.70 #71749

merged 1 commit into from Oct 24, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Oct 23, 2019

Motivation for this change

https://chromereleases.googleblog.com/2019/10/stable-channel-update-for-desktop_22.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Untested, please test.

A similar commit on release-19.09 had stable 78.0.3904.70 working fine.

Notify maintainers

cc @bendlas

@ofborg ofborg bot requested a review from bendlas October 23, 2019 04:10
This was referenced Oct 23, 2019
Merged
Merged
@grahamc grahamc merged commit aff7826 into NixOS:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @grahamc