Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Papis bump #71756

Merged
merged 2 commits into from Oct 23, 2019
Merged

Papis bump #71756

merged 2 commits into from Oct 23, 2019

Conversation

teto
Copy link
Member

@teto teto commented Oct 23, 2019 •
edited by jonringer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Oct 23, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-doi/default.nix Show resolved Hide resolved
pkgs/development/python-modules/python-doi/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from nico202 October 23, 2019 04:58
@teto
pythonPackages.python-doi: init at 0.1.1
6392a0e 
Required by the new papis 0.9
@teto
python3Packages.papis: 0.8.2 -> 0.9
070075d 
Many breaking changes, see the Changelog.
jonringer
jonringer approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (python38Packages.pytest broken on master)
diff LGTM
commit history LGTM
executable seems to work

https://github.com/NixOS/nixpkgs/pull/71756
1 package failed to build:
python38Packages.papis

3 package were build:
papis python37Packages.python-doi python38Packages.python-doi

@jonringer jonringer merged commit b87fc84 into NixOS:master Oct 23, 2019
@teto
Copy link
Member Author

teto commented Oct 23, 2019

thanks for the review.

@teto teto deleted the papis branch October 23, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@nico202 nico202 Awaiting requested review from nico202

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @jonringer