Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: add version 3.10 #71889

Merged
merged 1 commit into from Oct 25, 2019
Merged

protobuf: add version 3.10 #71889

merged 1 commit into from Oct 25, 2019

Conversation

stites
Copy link
Member

@stites stites commented Oct 24, 2019

Motivation for this change

Attempt to bump tensorflow-tensorboard to version 2.0

Things done

Protobuf on its own functions normally and passes its test suite. That said, I noticed that the python module fails its own test suite for any python-protobuf-3.x package. Can someone else confirm? This PR implicitly adds the protobuf 3.10 python package.

On the python side, I will note that tensorflow-tensorboard-2.0 tests pass using protobuf-3.10 -- this test suite should have heavy dependence on protobuf and might be a good proxy(?)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc (no maintainers exist for protobuf)

@stites stites mentioned this pull request Oct 24, 2019
Closed
@stites stites mentioned this pull request Oct 24, 2019
Closed
10 tasks
@jonringer
Copy link
Contributor

@GrahamcOfBorg build protobuf3_10

jonringer
jonringer approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
build succeeds on darwin + linux

[3 built, 1 copied (4.9 MiB), 0.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71889
1 package were build:
protobuf3_10

@jonringer jonringer merged commit 9d90d5f into NixOS:master Oct 25, 2019
@stites stites deleted the protobuf-3-10 branch October 30, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stites @jonringer