Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorflow-tensorboard: 1.14.0 -> 2.0.0 #71890

Closed
wants to merge 1 commit into from
Closed

tensorflow-tensorboard: 1.14.0 -> 2.0.0 #71890

wants to merge 1 commit into from
+6 −4

Conversation

stites
Copy link
Member

@stites stites commented Oct 24, 2019

Motivation for this change

A transitive dependency of pytorch-1.3.0.
This may close #61173.

Things done

Passes test suite of tensorboard as well as cudaless pytorch-1.3.0.

I noticed in #71889 that python-protobuf packages fail test suites for 3.x versions. Not sure what to do about that, but this will not work on python2 without disabling protobuf checks.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@stites
tensorflow-tensorboard: 1.14.0 -> 2.0.0

Verified

This commit was signed with the committer’s verified signature. The key has expired.
stites Sam Stites
GPG key ID: 3E4CA1513C04EE76
Expired
Verified
Learn about vigilant mode
81b31f0
@stites stites mentioned this pull request Oct 24, 2019
Closed
@ofborg ofborg bot requested a review from abbradar October 24, 2019 04:19
@prusnak
Copy link
Member

prusnak commented Nov 17, 2019 •
edited
Loading

I'd say we don't want to bump the package to 2.x and rather put 2.x in a separate package.

See #70910 (comment)

(tensorflow-tensorboard was updated to 1.15.0 meanwhile in 152d2fd)

@jonringer
Copy link
Contributor

the tensorflow2 bump has been pretty disruptive, and most libraries still are only compatible with 1.*.

I think it will be a good while before we can transition to tensorflow 2, and the nature of python packages disallows us from really having more than 1 version of a package at a time

@infinisil
Copy link
Member

Ping @FRidh, would it be okay to have two tensorboard packages?

@cdepillabout cdepillabout mentioned this pull request Feb 28, 2020
Merged
10 tasks
@cdepillabout
Copy link
Member

#81278 bumps tensorboard to 2.1.0, so this PR shouldn't be needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@jonringer jonringer

@abbradar abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[19.03] tensorflow-tensorboard requires tensorflow python module to be importable
5 participants
@stites @prusnak @jonringer @infinisil @cdepillabout