Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bibata-extra-cursors,bibata-cursors-translucent: init (git revs) #71840

Merged
merged 3 commits into from Oct 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 23, 2019

Motivation for this change

More bibata! Muahaha

There's an adapta variant out there as well, if anyone wants to add it
too :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

  • Tested cursors load and at least work for the more common cursors

@ofborg ofborg bot requested a review from rawkode October 23, 2019 18:04
@dtzWill dtzWill merged commit 5adf934 into NixOS:master Oct 24, 2019
@dtzWill dtzWill deleted the feature/more-bibata branch October 24, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant