New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fdroidserver: fix gradlew-fdroid interpreter #71838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
seems like it could still use some love, it tries to install the gradle versions back into the store path
[nix-shell:~/.cache/nix-review/pr-71838]$ ./results/fdroidserver/bin/gradlew-fdroid --help
No suitable gradle version found - defaulting to 5.1.1
Downloading missing gradle version 5.1.1
/run/user/1000/tmp.Wg5t8vmICj/gradle-5.1.1-bin.zip: OK
mkdir: cannot create directory ‘./results/fdroidserver/versions/’: Read-only file system
checkdir: cannot create extraction directory: ./results/fdroidserver/versions
Read-only file system
mv: cannot stat './results/fdroidserver/versions/gradle-5.1.1': No such file or directory
Running ./results/fdroidserver/versions/5.1.1/bin/gradle --help
./results/fdroidserver/bin/gradlew-fdroid: line 21: ./results/fdroidserver/versions/5.1.1/bin/gradle: No such file or directory
Some environment variables do help. This is kinda broken in gradlew-fdroid and I wonder if it should be "fixed" (worked around) in nixpkgs at all.
|
Thank you for your contributions.
|
6da93eb
to
4bf5dd0
Compare
Result of 1 package built:
|
Motivation for this change
gradlew-fdroid still had !/bin/bash
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @pmiddend