Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libressl_3_0: 3.0.1 -> 3.0.2 #71835

Merged
merged 3 commits into from Oct 24, 2019
Merged

libressl_3_0: 3.0.1 -> 3.0.2 #71835

merged 3 commits into from Oct 24, 2019

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Oct 23, 2019

Motivation for this change

LibreSSL 3.0.2 has been released upstream. Changelog.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @fpletz

@ofborg ofborg bot requested review from fpletz and thoughtpolice October 23, 2019 17:31
@fpletz
Copy link
Member

fpletz commented Oct 23, 2019

@GrahamcOfBorg build libressl_3_0

fpletz
fpletz approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also backport this.

Since this is the first stable release of the 3.0 branch we could also bump the default libressl attribute to libressl_3_0 on master.

@ruuda
libressl: 2.9.2 -> 3.0.2
57c8223
@ruuda
libressl_2_8: remove, not maintained anymore
671a118 
Stable LibreSSL releases are supported one year after their OpenBSD release.
OpenBSD 6.4 with this branch was released on 2018-10-18.
@ruuda
Copy link
Contributor Author

ruuda commented Oct 23, 2019

Since this is the first stable release of the 3.0 branch we could also bump the default libressl attribute to libressl_3_0 on master.

I added a commit that changes the default to 3.0. I also added a commit to remove 2.8. 2.8 was released with OpenBSD 6.4, which was released on 2018-10-18, more than one year ago. If I understand correctly, that makes 2.8 unsupported now.

@ofborg ofborg bot requested review from thoughtpolice and fpletz October 23, 2019 20:07
@fpletz
Copy link
Member

fpletz commented Oct 23, 2019

Yup, exactly, thanks a lot!

@fpletz fpletz merged commit 3f9774c into NixOS:master Oct 24, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 1, 2019
@fpletz @dtzWill
Merge pull request NixOS#71835 from ruuda/libressl-302
4082c6c 
libressl_3_0: 3.0.1 -> 3.0.2

(cherry picked from commit 3f9774c)
@ruuda ruuda deleted the libressl-302 branch October 6, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ruuda @fpletz @thoughtpolice