Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: Enable KEYBOARD_APPLESPI #71812

Merged
merged 1 commit into from
Oct 25, 2019
Merged

linux: Enable KEYBOARD_APPLESPI #71812

merged 1 commit into from
Oct 25, 2019
+2 −0

Conversation

NeQuissimus
Copy link
Member

This is available for 5.3+ and enables support for
Apple trackpads and keyboards

Closes #71552

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @xaverdh

Sorry, something went wrong.

@NeQuissimus
linux: Enable KEYBOARD_APPLESPI
0973f67 
This is available for 5.3+ and enables support for
Apple trackpads and keyboards

Closes NixOS#71552
@NeQuissimus NeQuissimus added 0.kind: enhancement Add something new 6.topic: kernel The Linux kernel labels Oct 23, 2019
@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg test kernel-latest kernel-lts kernel-testing switchTest

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 and removed 6.topic: kernel The Linux kernel labels Oct 23, 2019
@globin globin merged commit 9a6d5a8 into NixOS:master Oct 25, 2019
@NeQuissimus NeQuissimus deleted the applespi branch October 25, 2019 17:40
@xaverdh
Copy link
Contributor

xaverdh commented Oct 25, 2019

Thanks!

@xaverdh xaverdh mentioned this pull request Oct 25, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement Add something new 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Build applespi driver into the kernel
3 participants
@NeQuissimus @xaverdh @globin