Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos-rebuild: support sudo + --target-host" #71788

Closed
wants to merge 1 commit into from
Closed

Revert "nixos-rebuild: support sudo + --target-host" #71788

wants to merge 1 commit into from
+3 −7

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 23, 2019

This reverts commit 263a81e.

Only because sudo is used locally does not mean it should be used on
the remote machine:

  • One might use sudo locally because the configuration is not readable by the current user
  • One might not want to type in a sudo password locally while it might be needed when deploying remotely.

Instead it might be better to rely on a proper flag.
cc @bjornfor

Also see #71143 (comment) for a better design.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@Mic92
Revert "nixos-rebuild: support sudo + --target-host"

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Mic92 Jörg Thalheim
GPG key ID: B3F5D81B0C6967C4
Expired
Verified
Learn about vigilant mode
3378722 
This reverts commit 263a81e.

Only because sudo is used locally does not mean it should be used on
the remote machine:

- One might use sudo locally because the configuration is not readable by the current user
- One might not want to type in a sudo password locally while it might be needed when deploying remotely.

Instead it might be better to rely on a proper flag.
cc @bjornfor

Also see NixOS#71143 (comment) for a better design.
@Mic92 Mic92 mentioned this pull request Oct 23, 2019
Merged
10 tasks
@Mic92 Mic92 added this to the 20.03 milestone Oct 23, 2019
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 23, 2019
@bjornfor
Copy link
Contributor

#71849 fixes this without reverting (it adds a proper flag).

@bjornfor
Copy link
Contributor

bjornfor commented Nov 7, 2019

#71849 was merged instead, closing this.

@bjornfor bjornfor closed this Nov 7, 2019
@Mic92 Mic92 deleted the revert-sudo branch July 23, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @bjornfor