Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.twisted: move twisted cache generation to postFixup #71792

Merged
merged 1 commit into from
Oct 23, 2019
Merged

python.pkgs.twisted: move twisted cache generation to postFixup #71792

merged 1 commit into from
Oct 23, 2019
+3 −1

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 23, 2019

The Python 2 build of twisted would fail when generating the cache. This
failure started occuring since the change was introduced that builds
setuptools as a wheel instead of as an egg,
90be4c2.

Turns out moving this step to postFixup solves the issue. I suppose it
is related to the order of site packages being evaluated, where
PYTHONPATH introduced additional ones.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@FRidh
python.pkgs.twisted: move twisted cache generation to postFixup
6ab609c 
The Python 2 build of twisted would fail when generating the cache. This
failure started occuring since the change was introduced that builds
setuptools as a wheel instead of as an egg,
90be4c2.

Turns out moving this step to postFixup solves the issue. I suppose it
is related to the order of site packages being evaluated, where
PYTHONPATH introduced additional ones.
@FRidh FRidh requested a review from jonringer as a code owner October 23, 2019 09:27
@FRidh FRidh mentioned this pull request Oct 23, 2019
Closed
10 tasks
timokau
timokau approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very weird, how would the change in intermediate representation change the load order? Changing $out after fixup isn't ideal, but since this fixes a regression we shouldn't delay merging.

Thanks a lot for debugging this!

@timokau timokau merged commit a2aeec6 into NixOS:master Oct 23, 2019
@FRidh FRidh deleted the twisted branch October 23, 2019 13:24
This was referenced Oct 23, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @timokau