Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openarena: add module and test #71789

Merged
merged 3 commits into from
Oct 26, 2019
Merged

openarena: add module and test #71789

merged 3 commits into from
Oct 26, 2019
+106 −0

Conversation

tomfitzhenry
Copy link
Contributor

Motivation for this change

A new NIxOS module and test for running a dedicated OpenArena server.

Motivation is 🔫🚀💥, I suppose.

Things done

nix-build on the test passes. To observe the test failing, remove the "+map oa_dm1" flag, which will cause openarena.service to not respond to getchallenge.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

n/a

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 23, 2019
dasJ
dasJ requested changes Oct 23, 2019
View reviewed changes
@tomfitzhenry tomfitzhenry requested a review from dasJ October 24, 2019 11:27
@aanderse
Copy link
Member

@GrahamcOfBorg test openarena

@aanderse
Copy link
Member

@tomfitzhenry please create another commit before this commit adding yourself to the maintainers-list.nix.

@tomfitzhenry
Copy link
Contributor Author

@aanderse Done: I have added myself to maintainers-list.nix and rebased that to be the first commit of this PR.

@tomfitzhenry
openarena: add module for dedicated server
230fc22
@tomfitzhenry
openarena: add test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6d90d17
@tomfitzhenry tomfitzhenry requested a review from aanderse October 25, 2019 13:59
aanderse
aanderse approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for your contribution 🎉

@aanderse
Copy link
Member

@GrahamcOfBorg eval

@aanderse aanderse merged commit 2921e8a into NixOS:master Oct 26, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 29, 2019
@aanderse @dtzWill
Merge pull request NixOS#71789 from tomfitzhenry/openarena-server
a1db35b 
openarena: add module and test
(cherry picked from commit 2921e8a)
@tomfitzhenry tomfitzhenry mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ

@aanderse aanderse

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomfitzhenry @aanderse @dasJ