Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3265f554ca60
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fa21e8c1bb8b
Choose a head ref

Commits on Oct 15, 2019

  1. networkmanager: enable polkit_agent

    Not sure why we had this disabled.
    This is for the nmcli/nmtui `agent` subcommand [0]
    which allows it to act as a polkit agent.
    
    > nmcli agent { secret | polkit | all }
    > Run nmcli as a NetworkManager secret agent, or polkit agent.
    
    For example, this is useful if you want to use nmcli/nmtui to authenti-
    cate with polkit on a headless server.
    
    [0]: https://developer.gnome.org/NetworkManager/stable/nmcli.html
    worldofpeace committed Oct 15, 2019
    Copy the full SHA
    15b0cff View commit details

Commits on Oct 16, 2019

  1. spidermonkey_60: 60.4.0 -> 60.9.0

    This is the last 60-esr I believe.
    
    - fixed multiple outputs (saves $out 2MB from $out)
    - updated the only patch we carry
    - symlinked `js` to `js60`, some packages using spidermonkey expects `js`. Might
      make it possible to drop 38 in the future.
    hedning committed Oct 16, 2019
    Copy the full SHA
    231432e View commit details
  2. spidermonkey_52: drop, as is unused

    `gnome-shell-extensions` switched over to `spidermonkey_60` in 3.34 leaving
    `spidermonkey_52` unused.
    hedning committed Oct 16, 2019
    Copy the full SHA
    18d7929 View commit details

Commits on Oct 17, 2019

  1. pinentry: build with multiple outputs in single drv

    Co-authored-by: Florian Klink <flokli@flokli.de>
    Co-authored-by: worldofpeace <worldofpeace@protonmail.ch>
    3 people committed Oct 17, 2019
    Copy the full SHA
    cb0adc1 View commit details
  2. Copy the full SHA
    511b182 View commit details
  3. nixos/gnupg: add option for setting pinentry flavours

    Co-authored-by: Florian Klink <flokli@flokli.de>
    2 people authored and worldofpeace committed Oct 17, 2019
    Copy the full SHA
    c257626 View commit details
  4. gnupg: disable gui/pinentry support by default

    This solves the dependency cycle in gcr alternatively so there won't be
    two gnupg store paths in a standard NixOS system which has udisks2 enabled
    by default.
    
    NixOS users are expected to use the gpg-agent user service to pull in the
    appropriate pinentry flavour or install it on their systemPackages and set
    it in their local gnupg agent config instead.
    
    Co-authored-by: Florian Klink <flokli@flokli.de>
    2 people authored and worldofpeace committed Oct 17, 2019
    2
    Copy the full SHA
    3d832de View commit details
  5. Revert "installer: Disable udisks"

    This reverts commit 571fb74.
    
    The dependency on gtk2 was removed.
    
    Co-authored-by: Florian Klink <flokli@flokli.de>
    2 people authored and worldofpeace committed Oct 17, 2019
    Copy the full SHA
    ec6224b View commit details
  6. Copy the full SHA
    36756e9 View commit details
  7. Merge staging-next into staging

    FRidh committed Oct 17, 2019
    Copy the full SHA
    fc6706f View commit details
  8. Remove references to the nixpkgs-channels repo

    Channel branches are now provided in the nixpkgs repo.
    
    Issue #71176.
    edolstra committed Oct 17, 2019
    Copy the full SHA
    5b324c1 View commit details

Commits on Oct 18, 2019

  1. python: pytz: 2019.1 -> 2019.3

    FRidh committed Oct 18, 2019
    Copy the full SHA
    5d0b430 View commit details
  2. Copy the full SHA
    7728eda View commit details
  3. Copy the full SHA
    dc410db View commit details
  4. Copy the full SHA
    501314c View commit details
  5. python: pytest: 5.1.0 -> 5.2.1

    FRidh committed Oct 18, 2019
    Copy the full SHA
    bff8343 View commit details
  6. Copy the full SHA
    7181aca View commit details
  7. Revert "update-python-libraries: use version key for latest release (#…

    …68857)"
    
    This broke support for --target.
    
    This reverts commit e8c29fa.
    FRidh committed Oct 18, 2019
    Copy the full SHA
    aedf4fc View commit details
  8. Copy the full SHA
    3e01504 View commit details
  9. python: Mako: 1.0.12 -> 1.0.14

    FRidh committed Oct 18, 2019
    Copy the full SHA
    7cf6312 View commit details
  10. python: adal: 1.2.1 -> 1.2.2

    FRidh committed Oct 18, 2019
    Copy the full SHA
    c465f71 View commit details
  11. python: aenum: 2.1.2 -> 2.1.4

    FRidh committed Oct 18, 2019
    Copy the full SHA
    aa9af6b View commit details
  12. python: aiohue: 1.9.1 -> 1.9.2

    FRidh committed Oct 18, 2019
    Copy the full SHA
    5b66874 View commit details
  13. Copy the full SHA
    f7111ac View commit details
  14. Copy the full SHA
    3991945 View commit details
  15. python: amqp: 2.5.1 -> 2.5.2

    FRidh committed Oct 18, 2019
    Copy the full SHA
    8d3a4e1 View commit details
  16. python: annoy: 1.16.0 -> 1.16.2

    FRidh committed Oct 18, 2019
    Copy the full SHA
    c185946 View commit details
  17. Copy the full SHA
    d38463e View commit details
  18. python: apprise: 0.8.0 -> 0.8.1

    FRidh committed Oct 18, 2019
    Copy the full SHA
    278bdf4 View commit details
  19. Copy the full SHA
    b3e4f01 View commit details
  20. python: astropy: 3.2.1 -> 3.2.2

    FRidh committed Oct 18, 2019
    Copy the full SHA
    dfac30d View commit details
  21. Copy the full SHA
    ffcbccf View commit details
  22. python: atomman: 1.2.6 -> 1.2.8

    FRidh committed Oct 18, 2019
    Copy the full SHA
    1a5b45f View commit details
  23. Copy the full SHA
    5ca1163 View commit details
  24. Copy the full SHA
    44a3def View commit details
  25. Copy the full SHA
    9116aef View commit details
  26. Copy the full SHA
    10021be View commit details
  27. Copy the full SHA
    f0e1baf View commit details
  28. Copy the full SHA
    2b0e249 View commit details
  29. python: blis: 0.4.0 -> 0.4.1

    FRidh committed Oct 18, 2019
    Copy the full SHA
    ae1df39 View commit details
  30. Copy the full SHA
    fb678c4 View commit details
  31. Copy the full SHA
    fc70591 View commit details
  32. Copy the full SHA
    805596a View commit details
  33. Copy the full SHA
    2e695be View commit details
  34. Copy the full SHA
    8f9cb8a View commit details
  35. python: bumps: 0.7.12 -> 0.7.13

    FRidh committed Oct 18, 2019
    Copy the full SHA
    f831efd View commit details
  36. Copy the full SHA
    4847d60 View commit details
  37. python: cheroot: 6.5.6 -> 6.5.8

    FRidh committed Oct 18, 2019
    Copy the full SHA
    cb73e0e View commit details
  38. Copy the full SHA
    8209c9b View commit details
  39. python: cmd2: 0.9.17 -> 0.9.19

    FRidh committed Oct 18, 2019
    Copy the full SHA
    51c3e7f View commit details
Showing 348 changed files with 2,547 additions and 1,885 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -51,9 +51,7 @@ system, [Hydra](https://hydra.nixos.org/).
Artifacts successfully built with Hydra are published to cache at
https://cache.nixos.org/. When successful build and test criteria are
met, the Nixpkgs expressions are distributed via [Nix
channels](https://nixos.org/nix/manual/#sec-channels). The channels
are provided via a read-only mirror of the Nixpkgs repository called
[nixpkgs-channels](https://github.com/NixOS/nixpkgs-channels).
channels](https://nixos.org/nix/manual/#sec-channels).

# Contributing

4 changes: 2 additions & 2 deletions doc/introduction.chapter.md
Original file line number Diff line number Diff line change
@@ -47,5 +47,5 @@ which also builds binary packages from the Nix expressions in Nixpkgs for
The binaries are made available via a [binary cache](https://cache.nixos.org).

The current Nix expressions of the channels are available in the
[`nixpkgs-channels`](https://github.com/NixOS/nixpkgs-channels) repository,
which has branches corresponding to the available channels.
[`nixpkgs`](https://github.com/NixOS/nixpkgs) repository in branches
that correspond to the channel names (e.g. `nixos-19.09-small`).
9 changes: 1 addition & 8 deletions doc/reviewing-contributions.xml
Original file line number Diff line number Diff line change
@@ -115,19 +115,12 @@
<para>
It is possible to rebase the changes on nixos-unstable or nixpkgs-unstable for easier review by running the following commands from a nixpkgs clone.
<screen>
<prompt>$ </prompt>git remote add channels https://github.com/NixOS/nixpkgs-channels.git <co
xml:id='reviewing-rebase-1' />
<prompt>$ </prompt>git fetch channels nixos-unstable <co xml:id='reviewing-rebase-2' />
<prompt>$ </prompt>git fetch origin nixos-unstable <co xml:id='reviewing-rebase-2' />
<prompt>$ </prompt>git fetch origin pull/PRNUMBER/head <co xml:id='reviewing-rebase-3' />
<prompt>$ </prompt>git rebase --onto nixos-unstable BASEBRANCH FETCH_HEAD <co
xml:id='reviewing-rebase-4' />
</screen>
<calloutlist>
<callout arearefs='reviewing-rebase-1'>
<para>
This should be done only once to be able to fetch channel branches from the nixpkgs-channels repository.
</para>
</callout>
<callout arearefs='reviewing-rebase-2'>
<para>
Fetching the nixos-unstable branch.
19 changes: 9 additions & 10 deletions nixos/doc/manual/development/sources.xml
Original file line number Diff line number Diff line change
@@ -13,17 +13,16 @@
<screen>
<prompt>$ </prompt>git clone https://github.com/NixOS/nixpkgs
<prompt>$ </prompt>cd nixpkgs
<prompt>$ </prompt>git remote add channels https://github.com/NixOS/nixpkgs-channels
<prompt>$ </prompt>git remote update channels
<prompt>$ </prompt>git remote update origin
</screen>
This will check out the latest Nixpkgs sources to
<filename>./nixpkgs</filename> the NixOS sources to
<filename>./nixpkgs/nixos</filename>. (The NixOS source tree lives in a
subdirectory of the Nixpkgs repository.) The remote
<literal>channels</literal> refers to a read-only repository that tracks the
Nixpkgs/NixOS channels (see <xref linkend="sec-upgrading"/> for more
subdirectory of the Nixpkgs repository.) The
<literal>nixpkgs</literal> repository has branches that correspond
to each Nixpkgs/NixOS channel (see <xref linkend="sec-upgrading"/> for more
information about channels). Thus, the Git branch
<literal>channels/nixos-17.03</literal> will contain the latest built and
<literal>origin/nixos-17.03</literal> will contain the latest built and
tested version available in the <literal>nixos-17.03</literal> channel.
</para>
<para>
@@ -40,15 +39,15 @@
Or, to base your local branch on the latest version available in a NixOS
channel:
<screen>
<prompt>$ </prompt>git remote update channels
<prompt>$ </prompt>git checkout -b local channels/nixos-17.03
<prompt>$ </prompt>git remote update origin
<prompt>$ </prompt>git checkout -b local origin/nixos-17.03
</screen>
(Replace <literal>nixos-17.03</literal> with the name of the channel you want
to use.) You can use <command>git merge</command> or <command>git
rebase</command> to keep your local branch in sync with the channel, e.g.
<screen>
<prompt>$ </prompt>git remote update channels
<prompt>$ </prompt>git merge channels/nixos-17.03
<prompt>$ </prompt>git remote update origin
<prompt>$ </prompt>git merge origin/nixos-17.03
</screen>
You can use <command>git cherry-pick</command> to copy commits from your
local branch to the upstream branch.
18 changes: 18 additions & 0 deletions nixos/doc/manual/release-notes/rl-2003.xml
Original file line number Diff line number Diff line change
@@ -84,6 +84,16 @@
</para>

<itemizedlist>
<listitem>
<para>
GnuPG is now built without support for a graphical passphrase entry
by default. Please enable the <literal>gpg-agent</literal> user service
via the NixOS option <literal>programs.gnupg.agent.enable</literal>.
Note that upstream recommends using <literal>gpg-agent</literal> and
will spawn a <literal>gpg-agent</literal> on the first invocation of
GnuPG anyway.
</para>
</listitem>
<listitem>
<para>
The <literal>dynamicHosts</literal> option has been removed from the
@@ -129,6 +139,14 @@
<listitem>
<para>SD images are now compressed by default using <literal>bzip2</literal>.</para>
</listitem>
<listitem>
<para>
OpenSSH has been upgraded from 7.9 to 8.1, improving security and adding features
but with potential incompatibilities. Consult the
<link xlink:href="https://www.openssh.com/txt/release-8.1">
release announcement</link> for more information.
</para>
</listitem>
</itemizedlist>
</section>
</section>
1 change: 0 additions & 1 deletion nixos/modules/config/no-x-libs.nix
Original file line number Diff line number Diff line change
@@ -34,7 +34,6 @@ with lib;
networkmanager-openvpn = super.networkmanager-openvpn.override { withGnome = false; };
networkmanager-vpnc = super.networkmanager-vpnc.override { withGnome = false; };
networkmanager-iodine = super.networkmanager-iodine.override { withGnome = false; };
pinentry = super.pinentry.override { gtk2 = null; gcr = null; qt4 = null; qt5 = null; };
gobject-introspection = super.gobject-introspection.override { x11Support = false; };
}));
};
6 changes: 5 additions & 1 deletion nixos/modules/installer/tools/tools.nix
Original file line number Diff line number Diff line change
@@ -120,7 +120,11 @@ in
# Some programs need SUID wrappers, can be configured further or are
# started in user sessions.
# programs.mtr.enable = true;
# programs.gnupg.agent = { enable = true; enableSSHSupport = true; };
# programs.gnupg.agent = {
# enable = true;
# enableSSHSupport = true;
# flavour = "gnome3";
# };
# List services that you want to enable:
3 changes: 0 additions & 3 deletions nixos/modules/profiles/installation-device.nix
Original file line number Diff line number Diff line change
@@ -31,9 +31,6 @@ with lib;
# Let the user play Rogue on TTY 8 during the installation.
#services.rogue.enable = true;

# Disable some other stuff we don't need.
services.udisks2.enable = mkDefault false;

# Use less privileged nixos user
users.users.nixos = {
isNormalUser = true;
39 changes: 38 additions & 1 deletion nixos/modules/programs/gnupg.nix
Original file line number Diff line number Diff line change
@@ -6,6 +6,19 @@ let

cfg = config.programs.gnupg;

xserverCfg = config.services.xserver;

defaultPinentryFlavor =
if xserverCfg.desktopManager.lxqt.enable
|| xserverCfg.desktopManager.plasma5.enable then
"qt"
else if xserverCfg.desktopManager.xfce.enable then
"gtk2"
else if xserverCfg.enable then
"gnome3"
else
null;

in

{
@@ -54,6 +67,20 @@ in
'';
};

agent.pinentryFlavor = mkOption {
type = types.nullOr (types.enum pkgs.pinentry.flavors);
example = "gnome3";
description = ''
Which pinentry interface to use. If not null, the path to the
pinentry binary will be passed to gpg-agent via commandline and
thus overrides the pinentry option in gpg-agent.conf in the user's
home directory.
If not set at all, it'll pick an appropriate flavor depending on the
system configuration (qt flavor for lxqt and plasma5, gtk2 for xfce
4.12, gnome3 on all other systems with X enabled, ncurses otherwise).
'';
};

dirmngr.enable = mkOption {
type = types.bool;
default = false;
@@ -64,6 +91,16 @@ in
};

config = mkIf cfg.agent.enable {
programs.gnupg.agent.pinentryFlavor = mkDefault defaultPinentryFlavor;

# This overrides the systemd user unit shipped with the gnupg package
systemd.user.services.gpg-agent = mkIf (cfg.agent.pinentryFlavor != null) {
serviceConfig.ExecStart = [ "" ''
${pkgs.gnupg}/bin/gpg-agent --supervised \
--pinentry-program ${pkgs.pinentry.${cfg.agent.pinentryFlavor}}/bin/pinentry
'' ];
};

systemd.user.sockets.gpg-agent = {
wantedBy = [ "sockets.target" ];
};
@@ -83,7 +120,7 @@ in
systemd.user.sockets.dirmngr = mkIf cfg.dirmngr.enable {
wantedBy = [ "sockets.target" ];
};

environment.systemPackages = with pkgs; [ cfg.package ];
systemd.packages = [ cfg.package ];

5 changes: 1 addition & 4 deletions nixos/modules/services/hardware/udisks2.nix
Original file line number Diff line number Diff line change
@@ -34,10 +34,7 @@ with lib;

services.dbus.packages = [ pkgs.udisks2 ];

system.activationScripts.udisks2 =
''
mkdir -m 0755 -p /var/lib/udisks2
'';
systemd.tmpfiles.rules = [ "d /var/lib/udisks2 0755 root root -" ];

services.udev.packages = [ pkgs.udisks2 ];

4 changes: 0 additions & 4 deletions nixos/tests/installer.nix
Original file line number Diff line number Diff line change
@@ -54,8 +54,6 @@ let
hardware.enableAllFirmware = lib.mkForce false;
services.udisks2.enable = lib.mkDefault false;
${replaceChars ["\n"] ["\n "] extraConfig}
}
'';
@@ -295,8 +293,6 @@ let
++ optional (bootLoader == "grub" && grubVersion == 1) pkgs.grub
++ optionals (bootLoader == "grub" && grubVersion == 2) [ pkgs.grub2 pkgs.grub2_efi ];

services.udisks2.enable = mkDefault false;

nix.binaryCaches = mkForce [ ];
nix.extraOptions =
''
3 changes: 1 addition & 2 deletions nixos/tests/os-prober.nix
Original file line number Diff line number Diff line change
@@ -51,12 +51,11 @@ let
hashed-mirrors =
connect-timeout = 1
'';
services.udisks2.enable = lib.mkForce false;
};
# /etc/nixos/configuration.nix for the vm
configFile = pkgs.writeText "configuration.nix" ''
{config, pkgs, ...}: ({
imports =
imports =
[ ./hardware-configuration.nix
<nixpkgs/nixos/modules/testing/test-instrumentation.nix>
];
4 changes: 2 additions & 2 deletions pkgs/applications/networking/browsers/firefox/packages.nix
Original file line number Diff line number Diff line change
@@ -17,10 +17,10 @@ rec {

firefox = common rec {
pname = "firefox";
ffversion = "69.0.2";
ffversion = "70.0";
src = fetchurl {
url = "mirror://mozilla/firefox/releases/${ffversion}/source/firefox-${ffversion}.source.tar.xz";
sha512 = "2ag1syrvlkch7vl151hkq8abf86p9v6b6gmgcbh26b8wfva1p1ss1x09h4w50zmcc6jq4q5mcxgf1sd9zna552jl90k1y4rqvrrzwl6";
sha512 = "1rjji7w0rf4b7h6hyllwav1xcbaiv37jmf5s0n0c3cwf9b76yhf8nhygm1a97m26f6rvbmhcv0dx4l8bh06cz9mcbbxy4lhsn43sr62";
};

patches = [
4 changes: 2 additions & 2 deletions pkgs/development/compilers/go/1.13.nix
Original file line number Diff line number Diff line change
@@ -30,11 +30,11 @@ in

stdenv.mkDerivation rec {
pname = "go";
version = "1.13.1";
version = "1.13.3";

src = fetchurl {
url = "https://dl.google.com/go/go${version}.src.tar.gz";
sha256 = "0n4k42bbrj5g9b1kczkfsih049v43vqzaps7n69gmfa4jpk59wc1";
sha256 = "1pz3423gw3z2zwcmk9l2c6v68w5is39gndq7502c9mbm8c226wag";
};

# perl is used for testing go vet
6 changes: 0 additions & 6 deletions pkgs/development/interpreters/python/cpython/2.7/default.nix
Original file line number Diff line number Diff line change
@@ -79,12 +79,6 @@ let
sha256 = "0l9rw6r5r90iybdkp3hhl2pf0h0s1izc68h5d3ywrm92pq32wz57";
})

(fetchpatch {
url = "https://github.com/python/cpython/commit/979daae300916adb399ab5b51410b6ebd0888f13.patch";
name = "CVE-2018-20852.patch";
sha256 = "0p838ycssd6abxzby69rhngjqqm59cmlp07910mpjx7lmsz049pb";
})

# Fix race-condition during pyc creation. Has a slight backwards
# incompatible effect: pyc symlinks will now be overridden
# (https://bugs.python.org/issue17222). Included in python >= 3.4,
Original file line number Diff line number Diff line change
@@ -93,8 +93,8 @@
_osx_support.customize_compiler(_config_vars)
_config_vars['CUSTOMIZED_OSX_COMPILER'] = 'True'

- (cc, cxx, opt, cflags, ccshared, ldshared, so_ext, ar, ar_flags) = \
- get_config_vars('CC', 'CXX', 'OPT', 'CFLAGS',
- (cc, cxx, cflags, ccshared, ldshared, so_ext, ar, ar_flags) = \
- get_config_vars('CC', 'CXX', 'CFLAGS',
- 'CCSHARED', 'LDSHARED', 'SO', 'AR',
- 'ARFLAGS')
+ (cc, cxx, ccshared, ldshared, ldcxxshared, so_ext, ar, ar_flags) = \
@@ -120,8 +120,7 @@
ldshared = ldshared + ' ' + os.environ['LDFLAGS']
+ ldcxxshared = ldcxxshared + ' ' + os.environ['LDFLAGS']
if 'CFLAGS' in os.environ:
- cflags = opt + ' ' + os.environ['CFLAGS']
+ cflags = os.environ['CFLAGS']
cflags = cflags + ' ' + os.environ['CFLAGS']
ldshared = ldshared + ' ' + os.environ['CFLAGS']
+ if 'CXXFLAGS' in os.environ:
+ cxxflags = os.environ['CXXFLAGS']
9 changes: 7 additions & 2 deletions pkgs/development/interpreters/python/default.nix
Original file line number Diff line number Diff line change
@@ -52,10 +52,10 @@ in {
sourceVersion = {
major = "2";
minor = "7";
patch = "16";
patch = "17";
suffix = "";
};
sha256 = "1mqfcqp5y8r0bfyr7ppl74n0lig45p9mc4b8adlcpvj74rhfy8pj";
sha256 = "0hds28cg226m8j8sr394nm9yc4gxhvlv109w0avsf2mxrlrz0hsd";
inherit (darwin) CF configd;
inherit passthruFun;
};
@@ -200,4 +200,9 @@ in {
ncurses = ncurses5;
};

graalpython37 = callPackage ./graalpython/default.nix {
self = pythonInterpreters.graalpython37;
inherit passthruFun;
};

})
21 changes: 21 additions & 0 deletions pkgs/development/interpreters/python/graalpython/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{ pkgs
, lib
, graalvm8
, passthruFun
, packageOverrides ? (self: super: {})
, self
}:

let
passthru = passthruFun {
inherit self packageOverrides;
implementation = "graal";
sourceVersion = graalvm8.version;
pythonVersion = "3.7";
libPrefix = "graalvm";
sitePackages = "jre/languages/python/lib-python/3/site-packages";
executable = "graalpython";
hasDistutilsCxxPatch = false;
pythonForBuild = pkgs.buildPackages.pythonInterpreters.graalpython37;
};
in lib.extendDerivation true passthru graalvm8
Loading