Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darktable 2.6.2 -> 2.6.3 #71762

Merged
merged 1 commit into from Oct 23, 2019
Merged

darktable 2.6.2 -> 2.6.3 #71762

merged 1 commit into from Oct 23, 2019

Conversation

paperdigits
Copy link
Contributor

@paperdigits paperdigits commented Oct 23, 2019 •
edited

Updating to newest minor version

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @goibhniu @flosse @mrVanDalo

@paperdigits
darktable 2.6.2 -> 2.6.3
71535ed 
Updating to newest minor version
@FRidh
Copy link
Member

FRidh commented Oct 23, 2019

@GrahamcOfBorg build darktable

mrVanDalo
mrVanDalo approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@mrVanDalo mrVanDalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on NixOS (19.03)
  • executables tested on NixOS (19.03)
  • all depending packages build

Lassulus
Lassulus approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, program started

@Lassulus Lassulus merged commit 2084e15 into NixOS:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@mrVanDalo mrVanDalo mrVanDalo approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@flosse flosse Awaiting requested review from flosse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paperdigits @FRidh @Lassulus @mrVanDalo