Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.twisted: disable for python2 #71741

Closed
wants to merge 1 commit into from
Closed

pythonPackages.twisted: disable for python2 #71741

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

zone_interface is now a namespace package and python2
can't load an environemtn without collisions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
pythonPackages.twisted: disable for python2
18fa98a 
zone_interface is now a namespace package and python2
can't load an environemtn without collisions
@jonringer jonringer requested a review from FRidh as a code owner October 23, 2019 02:25
@FRidh
Copy link
Member

FRidh commented Oct 23, 2019

That is not enough reason to disable it. Namespace packages function when using python.buildEnv with ignoreCollisions = true.

@jonringer
Copy link
Contributor Author

i guess, still very annoying to see it fail every time i review an upstream dependency

@jonringer jonringer closed this Oct 23, 2019
@jonringer jonringer deleted the disable-twisted branch October 23, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh