Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.2.23 -> 7.2.24, 7.3.10 -> 7.3.11 #71968

Merged
merged 1 commit into from Oct 25, 2019
Merged

php: 7.2.23 -> 7.2.24, 7.3.10 -> 7.3.11 #71968

merged 1 commit into from Oct 25, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Oct 25, 2019 •
edited

Motivation for this change

https://www.php.net/archive/2019.php#2019-10-24-1
https://www.php.net/archive/2019.php#2019-10-24-2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @etu

@ofborg ofborg bot requested review from etu and globin October 25, 2019 07:23
@aanderse
Copy link
Member Author 

~> nix-review pr 71968
16 package are marked as broken and were skipped:
hhvm php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 phpPackages-unit.php_excel phpPackages-unit.v8 phpPackages-unit.v8js phpPackages.php_excel phpPackages.v8

130 package were build:
arcanist drush icingaweb2 kcachegrind lsp-plugins matomo nagios nextcloud-news-updater phoronix-test-suite php php-embed php-unit php72 php72-embed php72-unit phpPackages-unit.apcu phpPackages-unit.apcu_bc phpPackages-unit.ast phpPackages-unit.box phpPackages-unit.composer phpPackages-unit.couchbase phpPackages-unit.event phpPackages-unit.igbinary phpPackages-unit.imagick phpPackages-unit.mailparse phpPackages-unit.memcached phpPackages-unit.mongodb phpPackages-unit.oci8 phpPackages-unit.pcs phpPackages-unit.pdo_sqlsrv phpPackages-unit.php-cs-fixer phpPackages-unit.php-parallel-lint phpPackages-unit.phpcbf phpPackages-unit.phpcs phpPackages-unit.phpstan phpPackages-unit.pinba phpPackages-unit.protobuf phpPackages-unit.psalm phpPackages-unit.redis phpPackages-unit.sqlsrv phpPackages-unit.xdebug phpPackages-unit.yaml phpPackages-unit.zmq php72Packages.apcu php72Packages.apcu_bc php72Packages.ast php72Packages.box php72Packages.composer php72Packages.couchbase php72Packages.event php72Packages.igbinary php72Packages.imagick php72Packages.mailparse php72Packages.memcached php72Packages.mongodb php72Packages.oci8 php72Packages.pcs php72Packages.pdo_sqlsrv php72Packages.php-cs-fixer php72Packages.php-parallel-lint php72Packages.phpcbf php72Packages.phpcs php72Packages.phpstan php72Packages.pinba php72Packages.protobuf php72Packages.psalm php72Packages.redis php72Packages.sqlsrv php72Packages.xdebug php72Packages.yaml php72Packages.zmq php73Packages-unit.apcu php73Packages-unit.apcu_bc php73Packages-unit.ast php73Packages-unit.box php73Packages-unit.composer php73Packages-unit.couchbase php73Packages-unit.event php73Packages-unit.igbinary php73Packages-unit.imagick php73Packages-unit.mailparse php73Packages-unit.memcached php73Packages-unit.mongodb php73Packages-unit.oci8 php73Packages-unit.pcs php73Packages-unit.pdo_sqlsrv php73Packages-unit.php-cs-fixer php73Packages-unit.php-parallel-lint php73Packages-unit.phpcbf php73Packages-unit.phpcs php73Packages-unit.phpstan php73Packages-unit.pinba php73Packages-unit.protobuf php73Packages-unit.psalm php73Packages-unit.redis php73Packages-unit.sqlsrv php73Packages-unit.xdebug php73Packages-unit.yaml phpPackages.apcu phpPackages.apcu_bc phpPackages.ast phpPackages.box phpPackages.composer phpPackages.couchbase phpPackages.event phpPackages.igbinary phpPackages.imagick phpPackages.mailparse phpPackages.memcached phpPackages.mongodb phpPackages.oci8 phpPackages.pcs phpPackages.pdo_sqlsrv phpPackages.php-cs-fixer phpPackages.php-parallel-lint phpPackages.phpcbf phpPackages.phpcs phpPackages.phpstan phpPackages.pinba phpPackages.protobuf phpPackages.psalm phpPackages.redis phpPackages.sqlsrv phpPackages.xdebug phpPackages.yaml pulseeffects qcachegrind unit wp-cli yle-dl

@globin globin merged commit 9671f33 into NixOS:master Oct 25, 2019
@aanderse aanderse deleted the php branch October 25, 2019 08:16
@etu etu mentioned this pull request Oct 25, 2019
Merged
10 tasks
@KamilaBorowska
Copy link
Member

This probably should be backported to stable.

@etu etu mentioned this pull request Oct 25, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @KamilaBorowska @globin