Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openorienteering-mapper: 0.8.4 -> 0.9.0 #71845

Merged
merged 1 commit into from Oct 23, 2019
Merged

openorienteering-mapper: 0.8.4 -> 0.9.0 #71845

merged 1 commit into from Oct 23, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Oct 23, 2019 •
edited

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/hn68ndkg7c97402w09953h3nrlf69wfn-OpenOrienteering-Mapper-0.8.4
/nix/store/hn68ndkg7c97402w09953h3nrlf69wfn-OpenOrienteering-Mapper-0.8.4	 658.7M
$ nix path-info -Sh /nix/store/nfcch1fr26l3jdf24pc3cb8iijgfxjac-OpenOrienteering-Mapper-0.9.0
/nix/store/nfcch1fr26l3jdf24pc3cb8iijgfxjac-OpenOrienteering-Mapper-0.9.0	 662.9M
Notify maintainers

cc @mpickering

jonringer
jonringer approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
gui starts up

[3 built, 4 copied (29.5 MiB), 7.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71845
1 package were build:
openorienteering-mapper

pkgs/applications/gis/openorienteering-mapper/default.nix
@@ -40,9 +40,6 @@ stdenv.mkDerivation rec {
"-DMapper_PACKAGE_GDAL=0"
]);

# Needs to be available when proj_api.h gets evaluted by CPP
NIX_CFLAGS_COMPILE = [ "-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good, they bumped their proj usage :) good

@jonringer
Copy link
Contributor

@GrahamcOfBorg build openorienteering-mapper

@jonringer jonringer merged commit f6b8a4d into NixOS:master Oct 23, 2019
@sikmir sikmir deleted the mapper branch October 23, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @jonringer