Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boomerang: 0.4.X -> 0.5.1, various fixes and cleanups #71833

Merged
merged 5 commits into from Oct 24, 2019
Merged

boomerang: 0.4.X -> 0.5.1, various fixes and cleanups #71833

merged 5 commits into from Oct 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 23, 2019

Motivation for this change

Newer, cleaner, better! :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (much cleaner! nice)
cli and gui both seem to work

[3 built, 72 copied (514.9 MiB), 116.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71833
1 package were build:
boomerang

pkgs/development/tools/boomerang/default.nix Outdated Show resolved Hide resolved
@dtzWill @jonringer
boomerang: be less verbose/explicit, save for problematic upstream
472832f 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@dtzWill dtzWill merged commit 092a835 into NixOS:master Oct 24, 2019
@dtzWill dtzWill deleted the update/boomerang-0.5.1 branch October 24, 2019 06:26
@dtzWill
Copy link
Member Author

dtzWill commented Oct 24, 2019

nix-review passes on NixOS
diff LGTM (much cleaner! nice)
cli and gui both seem to work

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @jonringer