frozen-bubble: init at 2.212 #71814
Merged
frozen-bubble: init at 2.212 #71814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of how nixpkgs works, all the SDL-umbrella libraries are in different folders. On a usual system, when using `sdl-config --libs`, this means that SDL_gfx would also be on the linker path. Some packages seem to depend on this being the case.
puckipedia
force-pushed
the
frozen-bubble
branch
2 times, most recently
from
c96cb96
to
12c5aba
Compare
puckipedia
force-pushed
the
frozen-bubble
branch
from
12c5aba
to
2fed5af
Compare
puckipedia
force-pushed
the
frozen-bubble
branch
from
2fed5af
to
9f52dab
Compare
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Nov 4, 2019
frozen-bubble: init at 2.212 (cherry picked from commit d690c20)
|
What about SDL2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
sdl-config --libsto return the library path of all SDL-like packages, the same way it does withsdl-config --cflagsright now. (the alternative to this would be to patchExtUtils::CBuilderto understand thatNIX_LDFLAGSexists, which should also be done at some point)SDL_Pangohas been fixed with a Debian patch, and a second custom patch.Alien::SDLhas been patched to skip trying to download sources from a now-defunct website, and to skip a broken testfrozen-bubblehas had-Wall -Werrorremoved, and proper linkage for SDL_mixer (necessary to avoid include header errors)Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @lovek323 (for the SDL change)