Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java-darwin: upgrade 8.0_121 -> 8.0_222 #71926

Merged
merged 1 commit into from Nov 2, 2019
Merged

java-darwin: upgrade 8.0_121 -> 8.0_222 #71926

merged 1 commit into from Nov 2, 2019

Conversation

DzmitrySudnik
Copy link
Contributor

@DzmitrySudnik DzmitrySudnik commented Oct 24, 2019 •
edited

Motivation for this change

Upgrading jdk8 version for darwin to catch up with jdk8 version for linux (based on 19.09 stable channel).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer @copumpkin @jfraudeau

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0 labels Oct 24, 2019
@LnL7 LnL7 merged commit 10875a7 into NixOS:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DzmitrySudnik @LnL7