Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass-checkup: init at 0.2.0 #71919

Merged
merged 1 commit into from Oct 25, 2019
Merged

pass-checkup: init at 0.2.0 #71919

merged 1 commit into from Oct 25, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 24, 2019

Motivation for this change

Pass checkup is a pass extension to check if your passwords is leaked against the haveibeenpwned database.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis @grahamc

@grahamc
Copy link
Member

grahamc commented Oct 24, 2019

Tested with nix-build -E '(import ./. {}).pass.withExtensions (ext: with ext; [ pass-checkup ])'. works great!

@etu etu changed the title pass-checkup: init at 0.1.1 pass-checkup: init at 0.2.0 Oct 24, 2019
@etu
Copy link
Contributor Author

etu commented Oct 24, 2019

@grahamc I've addressed your suggestions and updated this PR :-)

jonringer
jonringer approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commit history LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71919
1 package were build:
passExtensions.pass-checkup

@jonringer jonringer merged commit e8a36cd into NixOS:master Oct 25, 2019
@jonringer
Copy link
Contributor

patching was the right way to go, then you don't have to worry about how it gets invoked :).

@etu etu deleted the init-pass-checkup branch October 25, 2019 11:11
@etu etu mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace left review comments

@grahamc grahamc grahamc approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @grahamc @jonringer @worldofpeace