Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epsxe: fix link with openssl #71920

Merged
merged 2 commits into from Oct 25, 2019
Merged

epsxe: fix link with openssl #71920

merged 2 commits into from Oct 25, 2019

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Oct 24, 2019

Epsxe is hardcoded to build with openssl-1.0 (using libcrypto.so.1.0.0),
but current nixpkgs contains openssl-1.1, which provides
libcrypto.so.1.1.

This patchs just uses the previous version of the library.

Motivation for this change

epsxe is currently broken in nixpkgs: it fails at runtime link because it does not find libcrypto.so.

Things done

This PR introduces two changes:

  • Fix the build by using openssl_1_0 instead of the default openssl-1.1
  • Use autoPatchelfHook for the rpath rewriting. This simplify a bit the file but it also fails at buildtime.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@guibou
epsxe: fix link with openssl
5135fde 
Epsxe is hardcoded to build with openssl-1.0 (using libcrypto.so.1.0.0),
but current nixpkgs contains openssl-1.1, which provides
libcrypto.so.1.1.

This patchs just uses the previous version of the library.
@guibou
epsxe: use autoPatchelfHook instead of manual rpath overriding
06d25f1 
This simplifies the file AND generates failures at build time if a
needed dynamic library is not found during build time.
@guibou
Copy link
Contributor Author

guibou commented Oct 24, 2019

@flokli I don't know who I can ping, so I'm pinging you ;)

@ofborg ofborg bot requested a review from lukateras October 24, 2019 16:45
c0bw3b
c0bw3b approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@c0bw3b c0bw3b merged commit 4a2475c into NixOS:master Oct 25, 2019
c0bw3b pushed a commit that referenced this pull request Oct 25, 2019
@guibou @c0bw3b
epsxe: fix link with openssl
81b32ec 
* epsxe: fix link with openssl

Epsxe is hardcoded to build with openssl-1.0 (using libcrypto.so.1.0.0),
but current nixpkgs contains openssl-1.1, which provides
libcrypto.so.1.1.

This patchs just uses the previous version of the library.

* epsxe: use autoPatchelfHook instead of manual rpath overriding

This simplifies the file AND generates failures at build time if a
needed dynamic library is not found during build time.

Backport of #71920

(cherry picked from commit 4a2475c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@lukateras lukateras Awaiting requested review from lukateras

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guibou @c0bw3b