Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #71780

Merged
merged 484 commits into from Oct 24, 2019
Merged

Staging next #71780

merged 484 commits into from Oct 24, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

FRidh and others added 30 commits October 18, 2019 09:54
Does not seem to be needed. Hasn't been updated in over a year either.
We need this python version with its custom dependencies for aws_shell.
@FRidh
Copy link
Member Author

FRidh commented Oct 23, 2019

pkgsi686Linux.openssl_1_0_2 regression #71786.

@dtzWill
Copy link
Member

dtzWill commented Oct 23, 2019

Forgive the offtopic comment, but just wanted to say 👍 THANK YOU @FRidh for your constant work tackling these staging->staging-next->master monsters (well, sometimes monsters)! That's all! Your efforts are appreciated! ❤️

The Python 2 build of twisted would fail when generating the cache. This
failure started occuring since the change was introduced that builds
setuptools as a wheel instead of as an egg,
90be4c2.

Turns out moving this step to postFixup solves the issue. I suppose it
is related to the order of site packages being evaluated, where
PYTHONPATH introduced additional ones.
Builds fine now.

This reverts commit a1a8c96.
@FRidh
Copy link
Member Author

FRidh commented Oct 23, 2019

Thanks @dtzWill ! If you keep pushing those core package updates, then I'll handle these monsters ;-)

unbreaks pkgsi686Linux.openssl_1_0_2
@FRidh
Copy link
Member Author

FRidh commented Oct 23, 2019

Linux builds look good and are ready to go. Will wait till tomorrow for Darwin to catch up.
https://hydra.nixos.org/eval/1550390

@jonringer
Copy link
Contributor

oops, looks like I accidentally merged a conflict

@jonringer
Copy link
Contributor

scared to push the merge conflict change, don't want to kick off another hydra job

@FRidh
Copy link
Member Author

FRidh commented Oct 23, 2019

This hydra jobset evaluates only every 12 hours.

Tomorrow morning when more Darwin builds are finished I will solve the merge conflicts and merge it into master.

@FRidh FRidh merged commit fa21e8c into master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment