New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement assert_precondition (RFC) #19844
Comments
The wpt side of this change should also update the documentation added in #19628. |
The mozlog changes are up for review in https://phabricator.services.mozilla.com/D50175 |
https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 is now done, and the next step is for @jgraham to release mozlog 5.0. |
https://pypi.org/project/mozlog/5.0/ is now released, thanks @jgraham! |
Oops, we're going to get these errors:
@jgraham how can we resolve this? Do those also need new releases to fix this? Shall I send a mozilla-central patch that bumps the minor version of each? |
Discussed on IRC. I've sent https://phabricator.services.mozilla.com/D50595. |
Those three packages now have updated releases. Thanks @jgraham! |
mozlog itself updated in #19884 |
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
This came up at our improving interop with WPT talk at https://webkit.org/meeting/ today. When this is resolved, if there are tests that pass spuriously in WebKit, or that fail when they shouldn't have been run, then @cdumez @othermaciej @smfr @rniwa do you have specific cases for me to look at? I could try fixing a few of those as part of proving that this all works end-to-end. |
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
Any test in ambient-light, battery-status, bluetooth, vibration on Safari. |
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of #16689. Fixes #19844.
…ndition`, a=testonly Automatic update from web-platform-tests [testharness.js] introduce `assert_precondition` This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of web-platform-tests/wpt#16689. Fixes web-platform-tests/wpt#19844. -- [vibration] use `assert_precondition` to avoid spurious pass This demonstrates the use of `assert_precondition` for subtests. -- wpt-commits: 17543bc30bdf65838e9ec8e3b3b6fd210dced66e, a90e89fb031b0b357305ac9d874968d8451b1181 wpt-pr: 19993
…ndition`, a=testonly Automatic update from web-platform-tests [testharness.js] introduce `assert_precondition` This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of web-platform-tests/wpt#16689. Fixes web-platform-tests/wpt#19844. -- [vibration] use `assert_precondition` to avoid spurious pass This demonstrates the use of `assert_precondition` for subtests. -- wpt-commits: 17543bc30bdf65838e9ec8e3b3b6fd210dced66e, a90e89fb031b0b357305ac9d874968d8451b1181 wpt-pr: 19993
…ndition`, a=testonly Automatic update from web-platform-tests [testharness.js] introduce `assert_precondition` This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of web-platform-tests/wpt#16689. Fixes web-platform-tests/wpt#19844. -- [vibration] use `assert_precondition` to avoid spurious pass This demonstrates the use of `assert_precondition` for subtests. -- wpt-commits: 17543bc30bdf65838e9ec8e3b3b6fd210dced66e, a90e89fb031b0b357305ac9d874968d8451b1181 wpt-pr: 19993 UltraBlame original commit: 9b458e91114235eb43711dbac7a3acfe30c83fce
…ndition`, a=testonly Automatic update from web-platform-tests [testharness.js] introduce `assert_precondition` This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of web-platform-tests/wpt#16689. Fixes web-platform-tests/wpt#19844. -- [vibration] use `assert_precondition` to avoid spurious pass This demonstrates the use of `assert_precondition` for subtests. -- wpt-commits: 17543bc30bdf65838e9ec8e3b3b6fd210dced66e, a90e89fb031b0b357305ac9d874968d8451b1181 wpt-pr: 19993 UltraBlame original commit: 9b458e91114235eb43711dbac7a3acfe30c83fce
…ndition`, a=testonly Automatic update from web-platform-tests [testharness.js] introduce `assert_precondition` This depends on mozlog 5.0 for the new PRECONDITION_FAILED status: https://bugzilla.mozilla.org/show_bug.cgi?id=1589056 Implements web-platform-tests/rfcs#16. Includes parts of web-platform-tests/wpt#16689. Fixes web-platform-tests/wpt#19844. -- [vibration] use `assert_precondition` to avoid spurious pass This demonstrates the use of `assert_precondition` for subtests. -- wpt-commits: 17543bc30bdf65838e9ec8e3b3b6fd210dced66e, a90e89fb031b0b357305ac9d874968d8451b1181 wpt-pr: 19993 UltraBlame original commit: 9b458e91114235eb43711dbac7a3acfe30c83fce
This issue is to implement RFC #16: 'PRECONDITION_FAILED' subtest result (status)
There are at least two parts to this:
Then there will be many tests that could be updated a few of them included in #16689.
The text was updated successfully, but these errors were encountered: