Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.ack: v3.1.2 -> v3.1.3 #71949

Merged
merged 1 commit into from Oct 25, 2019
Merged

perlPackages.ack: v3.1.2 -> v3.1.3 #71949

merged 1 commit into from Oct 25, 2019

Conversation

stefanjaax
Copy link
Contributor

Motivation for this change

New point release:
https://metacpan.org/source/PETDANCE/ack-v3.1.3/Changes

v3.1.3      Sat Oct 19 19:23:48 CDT 2019
========================================
No changes to functionality.  Fixed a problem with version numbers.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Tested that ack works as usual.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323

@nh2
Copy link
Contributor

nh2 commented Oct 24, 2019

@GrahamcOfBorg build

@nh2
Copy link
Contributor

nh2 commented Oct 24, 2019

I've tested with sandbox:

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 25, 2019

@GrahamcOfBorg build perl528Packages.ack perl530Packages.ack

@aanderse aanderse merged commit 74ad305 into NixOS:master Oct 25, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 25, 2019
@aanderse @dtzWill
Merge pull request NixOS#71949 from stefanjaax/ack-3.1.3
d47db81 
perlPackages.ack: v3.1.2 -> v3.1.3

(cherry picked from commit 74ad305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stefanjaax @nh2 @c0bw3b @aanderse @Janik-Haag