Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] ghostscript: add patches for CVE-2019-10216, CVE-2019-14811, CVE-2019-14812, CVE-2019-14813 and some of CVE-2019-14817 #71872

Merged
merged 1 commit into from Oct 28, 2019
Merged

[r19.09] ghostscript: add patches for CVE-2019-10216, CVE-2019-14811, CVE-2019-14812, CVE-2019-14813 and some of CVE-2019-14817 #71872

merged 1 commit into from Oct 28, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 23, 2019

Motivation for this change

As with master (#69728), not all of the CVE-2019-14817 patch applies cleanly, but the parts that do should provide some protection.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
ghostscript: add patches for CVE-2019-10216, CVE-2019-14811, CVE-2019…
bd3f644 
…-14812, CVE-2019-14813 and some of CVE-2019-14817

as with master, not all of the CVE-2019-14817 patch applies cleanly, but
the parts that do should provide some protection
@ofborg ofborg bot requested a review from viric October 23, 2019 23:34
@FRidh FRidh added this to New in Staging Oct 24, 2019
@FRidh FRidh removed this from New in Staging Oct 24, 2019
@FRidh FRidh added this to Needs review in Staging (stable) Oct 24, 2019
@risicle
Copy link
Contributor Author

risicle commented Oct 27, 2019

@GrahamcOfBorg build ghostscript

@ckauhaus ckauhaus moved this from Needs review to Ready in Staging (stable) Oct 28, 2019
@ckauhaus
Copy link
Contributor

Able to build it on darwin and NixOS x86_64. Did a quick smoke test of the generated executables.

@ckauhaus ckauhaus merged commit 828d37d into NixOS:staging-19.09 Oct 28, 2019
@FRidh FRidh moved this from Ready to Merged in Staging (stable) Oct 28, 2019
@risicle risicle mentioned this pull request Nov 5, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging (stable)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @ckauhaus @FRidh