Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-{web,desktop}: 1.4.2 -> 1.5.0 #71870

Merged
merged 2 commits into from Oct 27, 2019
Merged

riot-{web,desktop}: 1.4.2 -> 1.5.0 #71870

merged 2 commits into from Oct 27, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Oct 23, 2019

Motivation for this change

Supersedes #71868

Untested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bachp @worldofpeace

@jonringer
Copy link
Contributor

closes #71868

@ofborg ofborg bot requested a review from worldofpeace October 23, 2019 23:20
@risicle
Copy link
Contributor

risicle commented Oct 27, 2019

nix-review is happy for me on macos 10.13, binary shows help.

@worldofpeace worldofpeace merged commit 55f826b into NixOS:master Oct 27, 2019
@worldofpeace
Copy link
Contributor

backported in 5635623 6908c4a

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacien @jonringer @risicle @worldofpeace