spdlog: 1.3.1 -> 1.4.2 #71876
Merged
spdlog: 1.3.1 -> 1.4.2 #71876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/spdlog/versions
c0bw3b
reviewed
Oct 24, 2019
There was a problem hiding this comment.
Result of nix-review pr 71876 1
3 package were build:
- nheko (spdlog_1)
- spdlog (spdlog_1)
- waybar (spdlog_1)
Just a slight issue in spdlog :
Manually-specified variables were not used by the project:
SPDLOG_BUILD_EXAMPLES
[...]
[ 34%] Built target exampleThe actual option is SPDLOG_BUILD_EXAMPLE -> fixing this
|
Forgot to paste: Result of 6 package were build:
|
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Oct 24, 2019
* spdlog: 1.3.1 -> 1.4.2 Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/spdlog/versions * spdlog: actually disable example build (cherry picked from commit 719313b)
jonringer
pushed a commit
that referenced
this pull request
Oct 25, 2019
* spdlog: 1.3.1 -> 1.4.2 Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/spdlog/versions * spdlog: actually disable example build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/spdlog/versions.
meta.description for spdlog is: '"Very fast, header only, C++ logging library."'.
meta.homepage for spdlog is: '"https://github.com/gabime/spdlog"
Release on GitHub
Compare changes on GitHub
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 1.4.2 with grep in /nix/store/4hl5hp61jgzfsr61ww5i5nmpjsb47mwb-spdlog-1.4.2
directory tree listing: https://gist.github.com/770db4efe50c27cb0515f92ae07b4501
du listing: https://gist.github.com/fbc17e87da424f829a14cf3b2527c622
Rebuild report (if merged into master) (click to expand)
16 total rebuild path(s)
4 package rebuild(s)
4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
nheko
spdlog
spdlog_1
waybar
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
cc @obadz for testing.