Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libogg: fix build on darwin #71956

Merged
merged 1 commit into from Oct 25, 2019
Merged

libogg: fix build on darwin #71956

merged 1 commit into from Oct 25, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Oct 25, 2019

weird, it suddenly started to work again

@marsam marsam closed this Oct 25, 2019
@marsam marsam deleted the fix-libogg-darwin branch October 25, 2019 09:58
@marsam marsam restored the fix-libogg-darwin branch October 25, 2019 13:26
@marsam marsam reopened this Oct 25, 2019
@marsam
Copy link
Contributor Author

marsam commented Oct 25, 2019

The error happens when libogg.dev is used, for instance libvorbis https://hydra.nixos.org/build/104229127

@marsam marsam merged commit d6fc52b into NixOS:master Oct 25, 2019
@marsam marsam deleted the fix-libogg-darwin branch October 25, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marsam