nixos/eternal-terminal: add firewall information #71917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingiun
force-pushed
the
eternal-terminal-open-firewall
branch
from
f0407cc
to
ddd2b03
Compare
c0bw3b
requested changes
Nov 14, 2019
There was a problem hiding this comment.
This is a recurring question, see #19504
The consensus is that opening port should be a deliberate admin decision and we don't want to do it automatically. Plus you may want to make a service reachable only on some interfaces but not all.
sshd is actually the exception here, not the model. :) It's here to avoid users locking themselves out too easily.
And even if a module provides a convenience option for the default NixOS firewall, the default should be false and not true.
Maybe a simpler approach is to just mention the prerequisite in the description of the module port option.
BTW adding yourselves to maintainers-list should be a separate commit. :)
pingiun
force-pushed
the
eternal-terminal-open-firewall
branch
from
ddd2b03
to
448270f
Compare
pingiun
force-pushed
the
eternal-terminal-open-firewall
branch
from
448270f
to
e7300ec
Compare
c0bw3b
approved these changes
Nov 18, 2019
c0bw3b
changed the title
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 19, 2020
(NixOS#71917) (cherry picked from commit 823852a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This was inspired by the openssh service, and others, which have the openFirewall option to open the port that the service uses. When enabling the service, one would expect it to work and opening firewalls is often necessary for this. As openssh has openFirewall enabled by default, I choose to do this as well.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
I added myself as a maintainer