Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luadoc #71802

Merged
merged 2 commits into from Oct 24, 2019
Merged

Luadoc #71802

merged 2 commits into from Oct 24, 2019

Conversation

teto
Copy link
Member

@teto teto commented Oct 23, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto
luaPackages.lualogging: init at 1.3.0-1
af6bdae 
Dependency of luadoc
@teto
luaPackages.luadoc: init at 3.0.1-1
1581898 
Used in vim plugins like nvim-terminal-lua to generate html docs.
@teto
Copy link
Member Author

teto commented Oct 23, 2019

@GrahamcOfBorg build luaPackages.luadoc

jonringer
jonringer approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on nixos

[11 built, 21 copied (14.6 MiB), 2.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71802
8 package were build:
lua51Packages.luadoc lua51Packages.lualogging luaPackages.luadoc luaPackages.lualogging lua53Packages.luadoc lua53Packages.lualogging luajitPackages.luadoc luajitPackages.lualogging

@teto teto merged commit 5f3db03 into NixOS:master Oct 24, 2019
@teto teto deleted the luadoc branch October 24, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: lua 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @jonringer