Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19.09: Nodejs backport #71902

Merged
merged 4 commits into from Oct 28, 2019
Merged

19.09: Nodejs backport #71902

merged 4 commits into from Oct 28, 2019

Conversation

wmertens
Copy link
Contributor

Motivation for this change

Update NodeJS versions to upstream stable, cherrypicking the commits from master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wmertens wmertens requested a review from marsam October 24, 2019 13:21
@wmertens wmertens mentioned this pull request Oct 24, 2019
Closed
@wmertens
Copy link
Contributor Author

@GrahamcOfBorg build nodejs-10_x nodejs-12_x

@FRidh FRidh changed the title Nodejs backport 19.09: Nodejs backport Oct 24, 2019
@wmertens
Copy link
Contributor Author

@FRidh thoughts on merging this? Looks like the build is too large for ofborg…

@Ma27 Ma27 self-assigned this Oct 26, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 26, 2019

Had those tabs open for a while now, will take care of this :)

@FRidh FRidh changed the base branch from nixos-19.09 to release-19.09 October 26, 2019 14:24
@marsam
Copy link
Contributor

marsam commented Oct 26, 2019

I think nodejs-10_x can safely backported, however nodejs-12_x needs #68748 and probably needs to go to staging-19.09

@wmertens wmertens changed the base branch from release-19.09 to staging-19.09 October 28, 2019 16:53
@wmertens
Copy link
Contributor Author

@marsam I added that patch and changed the base

@ofborg ofborg bot requested a review from cstrahan October 28, 2019 17:02
Ma27
Ma27 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally 👍

@Ma27 Ma27 merged commit 0141bd3 into NixOS:staging-19.09 Oct 28, 2019
@wmertens wmertens deleted the nodejs-backport branch October 29, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@marsam marsam Awaiting requested review from marsam

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees

@Ma27 Ma27

Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wmertens @Ma27 @marsam @dtzWill