Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] chromium: 77.0.3865.120 -> 78.0.3904.70 #71772

Merged
merged 1 commit into from Oct 24, 2019
Merged

[19.09] chromium: 77.0.3865.120 -> 78.0.3904.70 #71772

merged 1 commit into from Oct 24, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Oct 23, 2019 •
edited

Motivation for this change

Backport #71749 to 19.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested stable: YouTube, audio output, Octane 2.0, WebGL, Widevine all OK
I've been using stable for many hours and haven't seen any regressions.

Tested dev: GPU acceleration not OK; YouTube, audio output OK, Widevine FAIL (still need an updated patch for 79+)
dev GPU problems:

[20799:20799:1023/052939.953409:ERROR:gl_implementation.cc(282)] Failed to load /nix/store/z7w4yqr1npwbdl0s7bfckg1myz97ph3i-chromium-unwrapped-79.0.3941.4-wv/libexec/chromium/libGLESv2.so: /nix/store/z7w4yqr1npwbdl0s7bfckg1myz97ph3i-chromium-unwrapped-79.0.3941.4-wv/libexec/chromium/libGLESv2.so: cannot open shared object file: No such file or directory
[20799:20799:1023/052939.954535:ERROR:viz_main_impl.cc(180)] Exiting GPU process due to errors during initialization
[20821:20821:1023/052940.129480:ERROR:gpu_channel_manager.cc(397)] ContextResult::kFatalFailure: Failed to create shared context for virtualization.
Notify maintainers

cc @bendlas

@ofborg ofborg bot requested a review from bendlas October 23, 2019 06:39
@grahamc grahamc merged commit 14a9d91 into NixOS:release-19.09 Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @grahamc