Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19.09: release-lib.nix: initialize pkgs for the currentSystem #71794

Conversation

basvandijk
Copy link
Member

Backport of #71791.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Previously calling release-lib for only x86_64-darwin like:

  import ./release-lib.nix {
    supportedSystems = [ "x86_64-darwin" ];
  }

would still cause the packageSet to be evaluated for
x86_64-linux. This is annoying if you are evaluating this on
x86_64-darwin and your packageSet uses Import From Derivation to
produce a jobset. In that case you need to have a x86_64-linux build
machine configured in order to finish the evaluation.

This commit initializes `pkgs` for the currentSystem such that all IFD
derivations are build for the current system.

This shouldnt change anything for hydra.nixos.org since there
`builtins.currentSystem == "x86-64-linux"`.

(cherry picked from commit 76034ed502f8c8859e45c44725dfe290bf90821a)
@FRidh FRidh changed the title release-lib.nix: initialize pkgs for the currentSystem 19.09: release-lib.nix: initialize pkgs for the currentSystem Oct 23, 2019
@basvandijk basvandijk closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants