add more vim plugins and update #71954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be a little tedious, but it helps with git history to follow https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#adding-new-plugins-to-nixpkgs Do one commit to update the current plugins, then do a commit for each plugin you're adding :) the commits should look like: it's tedious, but if a given commit needs to be reverted or cherry-picked, then it becomes a lot easier |
|
@jonringer On it :) |
lovesegfault
force-pushed
the
add-vim-plugins
branch
from
eaa2bce
to
e0c6e82
Compare
|
@jonringer all fixed up :) |
jonringer
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM
commits LGTM
[37 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71954
18 package were build:
vimPlugins.ayu-vim vimPlugins.coc-snippets vimPlugins.deoplete-tabnine vimPlugins.fugitive-gitlab-vim vimPlugins.gentoo-syntax vimPlugins.lalrpop-vim vimPlugins.syntastic vimPlugins.tagbar vimPlugins.vim-airline vimPlugins.vim-better-whitespace vimPlugins.vim-flatbuffers vimPlugins.vim-gitgutter vimPlugins.vim-nftables vimPlugins.vim-pandoc vimPlugins.vim-protobuf vimPlugins.vim-snippets vimPlugins.vim-visual-multi vimPlugins.vimtex
|
Thanks @jonringer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added:
ayu-theme/ayu-vim
dcharbon/vim-flatbuffers
gentoo/gentoo-syntax
nfnty/vim-nftables
qnighy/lalrpop.vim
tbodt/deoplete-tabnine
uarun/vim-protobuf
Motivation for this change
Some of the plugins I use were missing
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @andir @gilligan