Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zsh-syntax-highlighting: Fix highlighting when ohMyZsh is enabled #71825

Merged
merged 1 commit into from
Nov 7, 2019
Merged

nixos/zsh-syntax-highlighting: Fix highlighting when ohMyZsh is enabled #71825

merged 1 commit into from
Nov 7, 2019
+2 −2

Conversation

AIDEA775
Copy link
Contributor

Motivation for this change

From zsh-syntax-highlighting:

It must be sourced after all custom widgets have been created
(i.e., after all zle -N calls and after running compinit).

If zsh-syntax-highlighting and ohMyZsh are enabled, the highlighting does not work propetly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@AIDEA775
nixos/zsh-syntax-highlighting: Fix highlighting when ohMyZsh is enabled
35ae47e 
From https://github.com/zsh-users/zsh-syntax-highlighting#faq:

"It must be sourced after all custom widgets have been created
(i.e., after all zle -N calls and after running compinit)."

zsh-syntax-highlighting must be sourced to the end.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 23, 2019
@matthewbauer matthewbauer merged commit c403d66 into NixOS:master Nov 7, 2019
@infinisil
Copy link
Member

Backported in 31e6910

@infinisil infinisil mentioned this pull request Jan 16, 2020
Closed
10 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AIDEA775 @infinisil @matthewbauer @Janik-Haag