Thanks, I was going to ask you about this change but I forgot. Two things:

1. I think it would make sense to dedicate the reset button to the reset signal, as opposed to declaring it both as a button and as a reset resource. In fact, after your change, platform.request("button", 0) will usually fail.
2. (Nit) In line with the convention for clocks, the resource should be called rst.

2. (Nit) In line with the convention for clocks, the resource should be called `rst`.

In same vain I have been wondering is clock inputs shouldn't just be called clk without the frequency in their name ?

In same vain I have been wondering is clock inputs shouldn't just be called clk without the frequency in their name ?

Good question. I admit that I carried this convention from oMigen without much thinking. But it seems occasionally useful (e.g. if the toolchain screws up the clock constraint, which happens more than I'd like, you can easily see it from the errors), and doesn't seem to do any harm.