Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerline-rs: 0.1.9 -> 0.2.0 #71976

Merged
merged 1 commit into from
Jan 11, 2020
Merged

powerline-rs: 0.1.9 -> 0.2.0 #71976

merged 1 commit into from
Jan 11, 2020
+5 −7

Conversation

jD91mZM2
Copy link
Member

Now finally uses crate2nix because it's awesome!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Oct 25, 2019 •
edited
Loading

@GrahamcOfBorg eval

EDIT: I guess I'm not a known user. I don't know why the build is failing...

@jD91mZM2 jD91mZM2 force-pushed the powerline-rs branch 2 times, most recently from 6478ece to 6abac91 Compare October 25, 2019 10:20
@rasendubi
Copy link
Member

I can reproduce the failure with nix-review. Try running the following command in the root of nixpkgs:

nix-env -f . -qaP --xml --out-path --show-trace --meta

@jD91mZM2
Copy link
Member Author

@rasendubi That opens some xml file in less, but errors with

error: while querying the derivation named 'lambdabot-5.2':
while evaluating the attribute 'buildInputs' of the derivation 'lambdabot-5.2' at /home/user/nixpkgs/pkgs/development/haskell-modules/generic-builder.nix:245:3:
while evaluating the attribute 'propagatedBuildInputs' of the derivation 'lambdabot-core-5.2' at /home/user/nixpkgs/pkgs/development/haskell-modules/generic-builder.nix:245:3:
while evaluating 'getOutput' at /home/user/nixpkgs/lib/attrsets.nix:464:23, called from undefined position:
while evaluating anonymous function at /home/user/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:156:17, called from undefined position:
attribute 'hslogger_1_3_0_0' missing, at /home/user/nixpkgs/pkgs/development/haskell-modules/configuration-common.nix:1186:114

@rasendubi
Copy link
Member

Strange. I'm getting the following error on both you branch and your branch+master

error: while evaluating 'callPackageWith' at /home/rasen/prg/nixpkgs/lib/customisation.nix:117:35, called from /home/rasen/prg/nixpkgs/pkgs/top-level/all-packages.nix:17257:18:
while evaluating 'makeOverridable' at /home/rasen/prg/nixpkgs/lib/customisation.nix:67:24, called from /home/rasen/prg/nixpkgs/lib/customisation.nix:121:8:
while evaluating anonymous function at /home/rasen/prg/nixpkgs/pkgs/tools/misc/powerline-rs/default.nix:1:1, called from /home/rasen/prg/nixpkgs/lib/customisation.nix:69:16:
while evaluating 'callPackageWith' at /home/rasen/prg/nixpkgs/lib/customisation.nix:117:35, called from /home/rasen/prg/nixpkgs/pkgs/tools/misc/powerline-rs/default.nix:7:13:
while evaluating 'makeOverridable' at /home/rasen/prg/nixpkgs/lib/customisation.nix:67:24, called from /home/rasen/prg/nixpkgs/lib/customisation.nix:121:8:
cannot import '/nix/store/gd1z521yinjik7lbkm5z53ggz5g5jis3-source', since path '/nix/store/q4vr5gridmdnwa1bx8k98d7hhvfwn4y6-source.drv' is not valid, at /home/rasen/prg/nixpkgs/lib/customisation.nix:119:45

@jD91mZM2
Copy link
Member Author

Manually specifying powerline-rs at the end of that command claimed no derivations existed with that name. Turns out pname and version don't work inside overrideAttrs.

@jD91mZM2
Copy link
Member Author

@rasendubi Are you on NixOS or some other setup?

@rasendubi
Copy link
Member

I'm on NixOS

@cdepillabout
Copy link
Member

@jD91mZM2 My guess is that this error is occurring because you are trying to "import-from-derivation".

Unfortunately hydra (and I guess ofborg) doesn't allow you to import nix-files from a derivation:

$ git checkout master
$ git pull
...
$ sudo nix-build -A powerline-rs --option allow-import-from-derivation false
/nix/store/dsak335rb6ydiq0ywhbira4cmga3w9nf-powerline-rs-0.1.9
$ hub checkout https://github.com/NixOS/nixpkgs/pull/71976
$ sudo nix-build -A powerline-rs --option allow-import-from-derivation false
error: attempted to realize '/nix/store/q4vr5gridmdnwa1bx8k98d7hhvfwn4y6-source.drv!out' during evaluation but 'allow-import-from-derivation' is false

@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Oct 25, 2019 •
edited
Loading

Oh, why not? :(

EDIT: Right, to not build at evaluation time

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 26, 2019
@rasendubi
Copy link
Member

@GrahamcOfBorg build powerline-rs

@jD91mZM2 jD91mZM2 force-pushed the powerline-rs branch 2 times, most recently from ea4ee47 to d61427d Compare October 28, 2019 09:37
@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Jan 7, 2020

bump?

jonringer
jonringer reviewed Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, build is failling:

installing
  rm: cannot remove '/nix/store/k48wghpga030phdk6yy6iahfrh1dmkf3-powerline-rs-0.2.0/lib/link': No such file or directory

@jD91mZM2 @jonringer
powerline-rs: 0.1.9 -> 0.2.0

Unverified

The committer email address is not verified.
Learn about vigilant mode
23d04f6 
Now *finally* uses crate2nix because it's awesome!

----------------

Squashed with:

Apply suggestions from code review

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
jonringer
jonringer approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
shows correct usage

[4 built, 3 copied (2.7 MiB), 0.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71976
1 package built:
powerline-rs

@jonringer
Copy link
Contributor

@GrahamcOfBorg build powerline-rs

@jonringer jonringer merged commit 884cbc5 into NixOS:master Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle

@rasendubi rasendubi

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jD91mZM2 @rasendubi @cdepillabout @jonringer @risicle