Backporting ACME v2 fix (#71291) to 19.09 #71953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 071d181)
(cherry picked from commit 6ac0e34)
Updating: - nixos module to use the new `account_reg.json` file. - use nixpkgs pebble for integration tests. Co-authored-by: Florian Klink <flokli@flokli.de> Replace certbot-embedded pebble (cherry picked from commit 38e8415)
Let's encrypt bumped ACME to V2. We need to update our nixos test to be compatible with this new protocol version. We decided to drop the Boulder ACME server in favor of the more integration test friendly Pebble. - overriding cacert not necessary - this avoids rebuilding lots of packages needlessly - nixos/tests/acme: use pebble's ca for client tests - pebble always generates its own ca which has to be fetched (cherry picked from commit 0c0af28)
|
@GrahamcOfBorg test acme |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/please-update-to-latest-19-09-if-using-letsencrypt/4595/1 |
|
Maybe have a release note? |
|
We did not do any changes on the API. The fix should be transparent to
the user.
Is it necessary?
|
|
I don't really see a reason too add a release notes - the backport PR was about keeping the current feature set (and functionality). |
10 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #71291 to 19.09 to fix let's encrypt certificate issuing.
Part of #70966.
CC @disassembler @aszlig @fpletz @flokli @c0bw3b @arianvp