renderdoc: 1.4 -> 1.5 (backport) #71961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
changed the title
|
Does 19.09 require the addOpenGLRunpath dance yet? If so, it might make sense to just backport #71057 |
In principle I believe so, although LD_LIBRARY_PATH is still getting set in my 19.09 environment and hence this PR is sufficient (and necessary) to get it working.
I'm on board with this. |
Ralith
force-pushed
the
renderdoc-backport
branch
from
166d155
to
db83ca6
Compare
Ralith
changed the title
|
Updated to a backport of 1.5. |
jansol
approved these changes
Oct 26, 2019
jansol
approved these changes
Oct 26, 2019
|
Backport in 872b6a2 |
|
@Ralith you should use |
|
Noted, thanks!
…On Thu, Nov 14, 2019, 12:52 Renaud ***@***.***> wrote:
@Ralith <https://github.com/Ralith> you should use git cherry-pick -x
when backporting, that way you retain the reference of the original commit
to master
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#71961?email_source=notifications&email_token=AAAZQ3SU3QEUU3A52KONJSTQTW3BBA5CNFSM4JE5Y622YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEDIBWQ#issuecomment-554074330>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZQ3S7GXAGNPDTSE2LTALQTW3BBANCNFSM4JE5Y62Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #71057, as current build crashes on startup.