Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-sdk: 255.0.0 -> 268.0.0 #71958

Merged
merged 1 commit into from Oct 29, 2019
Merged

google-cloud-sdk: 255.0.0 -> 268.0.0 #71958

merged 1 commit into from Oct 29, 2019

Conversation

pradyuman
Copy link
Member

@pradyuman pradyuman commented Oct 25, 2019 •
edited

Motivation for this change

Want to be up to date with the breaking changes since 255.0.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from zimbatm October 25, 2019 02:34
@flokli
Copy link
Contributor

flokli commented Oct 25, 2019

@GrahamcOfBorg build google-cloud-sdk

@risicle
Copy link
Contributor

risicle commented Oct 27, 2019

nix-review happy for me macos 10.13

@zimbatm zimbatm merged commit 78d9669 into NixOS:master Oct 29, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 21, 2020
@pradyuman @dtzWill
google-cloud-sdk: 255.0.0 -> 268.0.0 (NixOS#71958)
0f82e51 
(cherry picked from commit 78d9669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pradyuman @flokli @risicle @zimbatm