Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pydocumentdb: fix build #71962

Merged
merged 1 commit into from Oct 25, 2019
Merged

pythonPackages.pydocumentdb: fix build #71962

merged 1 commit into from Oct 25, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 25, 2019 •
edited

Motivation for this change

noticed it was broken when I rebased #71797

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner October 25, 2019 02:49
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.pydocumentdb python3Packages.pydocumentdb python38Packages.pydocumentdb

@jonringer
Copy link
Contributor Author

locally:

[19:44:10] jon@jon-desktop /home/jon/projects/nixpkgs (fix-pydoc)
$ nix build -f . pythonPackages.pydocumentdb python35Packages.pydocumentdb python36Packages.pydocumentdb python38Packages.pydocumentdb
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
[32 built, 52 copied (62.5 MiB), 41.3 MiB DL]

@jonringer
Copy link
Contributor Author 

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71962
3 package were build:
python27Packages.pydocumentdb python37Packages.pydocumentdb python38Packages.pydocumentdb

@jonringer
Copy link
Contributor Author

previously broken, merging

@jonringer jonringer merged commit d463f54 into NixOS:master Oct 25, 2019
@jonringer jonringer deleted the fix-pydoc branch October 25, 2019 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer