Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderdoc: fix build for new qt infrastructure #71960

Closed
wants to merge 1 commit into from
Closed

renderdoc: fix build for new qt infrastructure #71960

wants to merge 1 commit into from

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Oct 25, 2019

Motivation for this change

qrenderdoc is currently broken; this fixes it. See #65399 for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jansol

@Ralith Ralith mentioned this pull request Oct 25, 2019
Closed
@ofborg ofborg bot requested a review from jansol October 25, 2019 02:49
@jansol
Copy link
Contributor

jansol commented Oct 25, 2019

This is already fixed in #71057

@Ralith
Copy link
Contributor Author

Ralith commented Oct 26, 2019

Closing in favor of #71057.

@Ralith Ralith closed this Oct 26, 2019
@Ralith Ralith deleted the renderdoc branch October 26, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansol jansol Awaiting requested review from jansol

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ralith @jansol