Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address nextcloud "urgent security issue" w/nginx per upstream recs #71963

Merged
merged 1 commit into from Oct 25, 2019
Merged

Address nextcloud "urgent security issue" w/nginx per upstream recs #71963

merged 1 commit into from Oct 25, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 25, 2019

Motivation for this change

https://nextcloud.com/blog/urgent-security-issue-in-nginx-php-fpm/

  • Tweak the nginx config per upstream instructions
  • Fresh php releases, update

I put the urgent above in quotes not to suggest I disagree but rather
to underscore upstream's choice of language :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
      • Deploy! 馃槆
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Oct 25, 2019

The changes are straightforward but a second set of eyes re:details in new configs,
But given the way upstream is handling this, it's probably better safe than sorry :).

@ofborg ofborg bot requested review from etu and globin October 25, 2019 03:58
@etu
Copy link
Contributor

etu commented Oct 25, 2019

Since #71968 was merged, I think we should drop the php updates here? I don't see why it wouldn't conflict though.

@dtzWill dtzWill force-pushed the security/nextcloud17-php-and-nginx-config branch from f424c28 to f6c45bf Compare October 25, 2019 11:50
@Ma27 Ma27 added 9.needs: port to stable A PR needs a backport to the stable release. 1.severity: security labels Oct 25, 2019
@Ma27 Ma27 merged commit 4a5c0e0 into NixOS:master Oct 25, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 25, 2019

Backported as 3afeb36.

@dtzWill
Copy link
Member Author

dtzWill commented Oct 28, 2019

Thanks, @Ma27 !

@dtzWill dtzWill deleted the security/nextcloud17-php-and-nginx-config branch October 28, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
1.severity: security 6.topic: nixos 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @etu @Ma27